From nobody Tue Apr 28 16:54:40 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4mkl3Rhmz6bm9V for ; Tue, 28 Apr 2026 16:54:55 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4mkj5fwvz3YDM for ; Tue, 28 Apr 2026 16:54:53 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20240605:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of adrian.chadd@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=adrian.chadd@gmail.com Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-8b1f2b7f1bcso461386d6.1 for ; Tue, 28 Apr 2026 09:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777395293; cv=none; d=google.com; s=arc-20240605; b=SUqV8J6WC01+CmkXXMVIuMkAAmZnepAQt0pRhLCdOefR8XdVxwiFmV/v5XZErA8VBZ UBw796wkXSsf9AVD9I5w1mEWr5OQ4984+uVnDvIO8nA9k0BjvC3cTEg4Upd7lNgWCMam jxS3Zc/FNAXtSw9MY96TSPWCcCuyDXAwR8uI6ZJ/EOMWFyif1/6SvxEljDAddVTGzRmv B2PEbeyxXiLAhqwlDx2aXJ20sm1XmmnXJ6ske8ySMfKb4+7iVR4s2KcntmUpeQ3Mr+y3 fQVLf1bhgveZ10x6oZR888Xuu8kQeKPUKbrH/t7V6E+JQl3Z73r3C+aWAWsPpld99EDn zWtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=JQnyHsScwMfI/pruel2+3aOvx6O2WkjikPoFzTbPGGE=; fh=OCXpenO2X3WedWVtOpDy5MT9Jo7lkgm/bPsScpcTRhs=; b=MjgzB9VlXkmITNnswfdk4ii+k2VRC0Nq04wIgLYo9rz+FE6bn9yHPKGHwVpbQq40EE CLQ1yoKIdQDXE0BKAAfGNy3ZBs71mJGCI6/KS1BK88DZSeWqUP8FO3UAjEK/WGw3ucl8 W8j/N4hWokOzP5ymJVrD680WUYl8koECd5J0C5icFMyOf55CBczlgG5iXfJIdNty53+H kEtfzmOK2lFlKnk7XM+yWHGNBBfmnfBwWsSiSeHLkkq8AKnpWfvlerUQ2VthKoNG8j6f CsoiWpR1XaIk3NxaOtwyVqORAyl4/Cibj8wPjbFxVwbra3sRGWanmB5XtMSqQTvJcjFa WR1w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777395292; x=1778000092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JQnyHsScwMfI/pruel2+3aOvx6O2WkjikPoFzTbPGGE=; b=G1E3YCrf919WJalo1LLdwPvC8n/Tenc8KGlkjzOh2lFvv09G8lqzkBc5sD0r2sXfu7 PyWe/7WlIaaFEDfg4kXEhLor3HazrdYQdupCPMqCYc7oSConAMOqaYz6d1ihUEiDgeMH gWTQdZoIztbfcSbKfMgn1S5oW6ddJEjajXzpDHGC36RMoVu4EQTolpP8ZYkWYWgauhyu 9daF5TyfSG5eoxNem2yaVAZg5moNzMgA4nZqVXyYJUSvLI3NIA63WBziIVC4A7ImIO2y rg7x0zQb8gLwVfnar3zPJ51aiTQ2bgL3cq/ETjTXxtGpcSNVW6rtlEJnSL9vAIhIJIhy 8/rQ== X-Forwarded-Encrypted: i=1; AFNElJ8ZtKbG5X+QSH/nHmbjL7Nd1Js5/8CZ3sWkDOG+y39hoQBzZTxNl0Q5DH3KPWcpPEuhZzM1n+jTCra8O0Om8NaTN4e2zQ==@freebsd.org X-Gm-Message-State: AOJu0YwpxGQ+y0GdyYck+1Fw6ZADYxmKmeicfw/A9LtWl+2akn6k/Jzl /3mk2uKE3AYZ9afgHDNq6tdchknYvmnKkdc1ESDIG4SaKTUDwg55iLAvqDv2nNqR/ruxpv9GKZ2 LP77+q6xkTFZ+AVlkMnYZF3fnC2XW4QQ= X-Gm-Gg: AeBDieu65WNVU0EeSG+CWAkXwnfz9tXONZN/tPar8XkaxKARRLhaVGKn7dT6gDwK1CC QsccLD1ROhdWCIIt1dfPipJK7O6kc8aqbbBglDCJuFGi9v+83eUmb8hwbVFjw71lMh37Xnx/l7e bua6zVlj38HaoTH+iWRvDOmjcqXpGdB8xUS4tPEI5lmE72H+GtZPDX8CCrBdxyJ/oji5VUi7AMS N/pCbSZSnnEwS37qYSx3QdqfAHH9gqyapg4ZC1YMNxCnfUYADkDtaQ0BwEJHiK26rtuZtASHAK0 xiUcNZvAQloPHFOaiQ2hU/RIg0dOkIMIcWg2lULh4yYMumaQcImdgT1wL2K7uc3BjrQyZ3kslSL c1TaUM1sfRM8fv9D85TkiTD6+CF72C4OEcRL7JSqLLT7nB/kjnMKIIV7oIc/9S05GfFyQ X-Received: by 2002:a05:6214:d89:b0:8ac:a6f7:8a6d with SMTP id 6a1803df08f44-8b3e38fa1f5mr49698696d6.13.1777395292561; Tue, 28 Apr 2026 09:54:52 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69d12614.3d42a.5c3f48a2@gitrepo.freebsd.org> In-Reply-To: <69d12614.3d42a.5c3f48a2@gitrepo.freebsd.org> From: Adrian Chadd Date: Tue, 28 Apr 2026 09:54:40 -0700 X-Gm-Features: AVHnY4IOrscQmEEBKw1zSyvuOFs1Wpt6IHNyeX_pIxEUhnjgFq32tnNt5JmTFbM Message-ID: Subject: Re: git: 0b39d72d0491 - main - virtio: use modern mode for transitional device by default To: Michael Tuexen Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?UTF-8?B?VGltbyBWw7Zsa2Vy?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-1.80 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_SPAM_MEDIUM(1.00)[0.999]; NEURAL_HAM_SHORT(-0.90)[-0.898]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.49:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TAGGED_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.49:from]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[] X-Rspamd-Queue-Id: 4g4mkj5fwvz3YDM X-Spamd-Bar: - hi! FWIW, this has broken virtio on qemu ppc64 pseries VMs: ``` vtnet0: numa-domain 0 on virtio_pci0 virtio_pci0: virtqueue 1 (vtnet0-tx0) does not exist (size is zero) virtio_pci0: cannot allocate virtqueue 1: 19 vtnet0: cannot allocate virtqueues device_attach: vtnet0 attach returned 19 virtio_pci1: port 0x100-0x17f mem 0x81040000-0x81040fff,0x210000010000-0x210000013fff irq 4611 at device 3.0 numa-domain 0 on pci0 vtblk0: numa-domain 0 on virtio_pci1 qemu-system-ppc64: wrong value for queue_enable 100 ``` Is there any way to detect that we're running in an environment where the new way won't work? The snippet in my qemu setup is: ``` -drive file=3Dppc64be-1.qcow2,format=3Dqcow2,id=3Dhd0,if=3Dnone \ -device virtio-blk-pci,drive=3Dhd0 \ -drive file=3Dppc64be-data.qcow2,format=3Dqcow2,id=3Dhd1,if=3Dnone = \ -device virtio-blk-pci,drive=3Dhd1 \ -netdev tap,id=3Dnd0,ifname=3Dtap1 -device virtio-net,netdev=3Dnd0,mac=3D00:08:01:13:00:01 ``` -adrian On Sat, 4 Apr 2026 at 07:54, Michael Tuexen wrote: > > The branch main has been updated by tuexen: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0b39d72d0491c77e3e9883015b= 1fac46663c71de > > commit 0b39d72d0491c77e3e9883015b1fac46663c71de > Author: Timo V=C3=B6lker > AuthorDate: 2026-04-04 14:49:54 +0000 > Commit: Michael Tuexen > CommitDate: 2026-04-04 14:49:54 +0000 > > virtio: use modern mode for transitional device by default > > This patch changes the default value of the loader tunable > hw.virtio.pci.transitional to 1. This means, virtio uses the > modern mode for transitional devices by default. > > The return values of vtpci_modern_probe() and vtpci_legacy_probei() > were chosen to prefer modern mode, but hw.virtio.pci.transitional=3D0 > prevents modern mode. > Setting hw.virtio.pci.transitional to 1 by default seems a better fit= . > > Reviewed by: tuexen > Differential Revision: https://reviews.freebsd.org/D55894 > --- > share/man/man4/virtio.4 | 2 +- > sys/dev/virtio/pci/virtio_pci_modern.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/share/man/man4/virtio.4 b/share/man/man4/virtio.4 > index 8252cc1b7954..6af6300b1cee 100644 > --- a/share/man/man4/virtio.4 > +++ b/share/man/man4/virtio.4 > @@ -114,7 +114,7 @@ use the legacy > .Nm > driver > .Pq 0 . > -The default value is 0. > +The default value is 1. > .El > .Sh SEE ALSO > .Xr virtio_balloon 4 , > diff --git a/sys/dev/virtio/pci/virtio_pci_modern.c b/sys/dev/virtio/pci/= virtio_pci_modern.c > index 108fd2b5f8e9..baf7c448bb95 100644 > --- a/sys/dev/virtio/pci/virtio_pci_modern.c > +++ b/sys/dev/virtio/pci/virtio_pci_modern.c > @@ -191,7 +191,7 @@ static void vtpci_modern_write_device_8(struct vtpci_= modern_softc *, > /* Tunables. */ > SYSCTL_DECL(_hw_virtio_pci); > > -static int vtpci_modern_transitional =3D 0; > +static int vtpci_modern_transitional =3D 1; > SYSCTL_INT(_hw_virtio_pci, OID_AUTO, transitional, CTLFLAG_RDTUN, > &vtpci_modern_transitional, 0, > "If 0, a transitional VirtIO device is used in legacy mode; otherwis= e, in modern mode."); >