Date: Mon, 04 Jan 2016 16:54:40 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205883] databases/rrdtool: dejavu option logic broken Message-ID: <bug-205883-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205883 Bug ID: 205883 Summary: databases/rrdtool: dejavu option logic broken Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: zeising@FreeBSD.org Reporter: marino@FreeBSD.org Flags: maintainer-feedback?(zeising@FreeBSD.org) Assignee: zeising@FreeBSD.org rrdtool makefile has these lines in it: .if exists(${LOCALBASE}/share/fonts/dejavu) || ${PORT_OPTIONS:MDEJAVU} RUN_DEPENDS+=3D dejavu>0:${PORTSDIR}/x11-fonts/dejavu .endif Besides being a questionable technique, it doesn't work as intended. The dejavu dependency will be packaged 100% of the time regardless of value of = the option or if the rrdtool is built in a clean jail (where share/fonts/dejavu doesn't exist in theory) Why? because xorg-fonts-truetype (from pango) pulls it in, and by the time it's packaged, share/fonts/dejavu exists. `-- Installing xorg-fonts-truetype-7.7_1... | `-- Installing font-misc-meltho-1.0.3_3... | | `-- Installing mkfontdir-1.0.7... | | `-- Installing mkfontscale-1.1.2... | | | `-- Installing libfontenc-1.1.3... | | | `-- Extracting libfontenc-1.1.3: ...... done | | `-- Extracting mkfontscale-1.1.2: .. done | | `-- Extracting mkfontdir-1.0.7: .. done | `-- Extracting font-misc-meltho-1.0.3_3: .......... done | `-- Installing font-bh-ttf-1.0.3_3... | `-- Extracting font-bh-ttf-1.0.3_3: .......... done | `-- Installing font-misc-ethiopic-1.0.3_3... | `-- Extracting font-misc-ethiopic-1.0.3_3: .. done | `-- Installing dejavu-2.35... | `-- Extracting dejavu-2.35: .......... done I think the best approach is remove the override of the dejavu option. Eit= her that, or force it as an unconditional RUN depends. The current method is broken. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205883-13>