From owner-dev-commits-src-all@freebsd.org Tue Apr 20 16:10:07 2021 Return-Path: <owner-dev-commits-src-all@freebsd.org> Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DE1EF5DD89B; Tue, 20 Apr 2021 16:10:07 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FPpYW4Zjbz4vRF; Tue, 20 Apr 2021 16:10:07 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 13KG9wQo071569; Tue, 20 Apr 2021 09:09:58 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 13KG9w0e071568; Tue, 20 Apr 2021 09:09:58 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> Message-Id: <202104201609.13KG9w0e071568@gndrsh.dnsmgr.net> Subject: Re: git: 686cf5468c4a - main - flex: Regen bootstrap files In-Reply-To: <5dcdd0e7-2bb4-36ae-ec45-404e421cf180@FreeBSD.org> To: Jung-uk Kim <jkim@freebsd.org> Date: Tue, 20 Apr 2021 09:09:58 -0700 (PDT) CC: rgrimes@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4FPpYW4Zjbz4vRF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/> List-Post: <mailto:dev-commits-src-all@freebsd.org> List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 20 Apr 2021 16:10:07 -0000 > On 21. 4. 20., Rodney W. Grimes wrote: > >> The branch main has been updated by jkim: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=686cf5468c4a85c2a6385cdbab2383900876a41d > >> > >> commit 686cf5468c4a85c2a6385cdbab2383900876a41d > >> Author: Jung-uk Kim <jkim@FreeBSD.org> > >> AuthorDate: 2021-04-19 18:20:51 +0000 > >> Commit: Jung-uk Kim <jkim@FreeBSD.org> > >> CommitDate: 2021-04-19 18:20:51 +0000 > >> > >> flex: Regen bootstrap files > >> > >> This also partially reverts r326025 (8a16b7a18f5d). I do not see any > >> point of adding SPDX tag in generated file. > > > > The SPDX identifies the copyright that follows it, so please put this back. > > It is a generated file. If you really think it is necessary, you need > to patch its source, i.e., contrib/flex/src/parse.y, and regen the file. Just because it is a generated file does not change the fact that its contents are copyrighted. Leaving the copyright out at best defaults to Bern convention, so the fact of the mater is the contents is copyrighted, and it is best to explicitly state that it is. > > However, I don't see much sense in automatically adding BSD license in > every generated file in the first place. In fact, I think it should not > appear on generated file at all. It may say something along the line of > "generated by flex" instead but IANAL. Well, someone before you did see since in it, and hence put that SPDX in it. > Jung-uk Kim -- Rod Grimes rgrimes@freebsd.org