Date: Thu, 18 Sep 2008 21:27:58 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.ORG> To: John Baldwin <jhb@FreeBSD.ORG> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h Message-ID: <45929AC0-E324-4CE5-962B-DEDFA9BD173C@FreeBSD.ORG> In-Reply-To: <200809181024.35437.jhb@freebsd.org> References: <200809181212.m8ICCmgw043093@repoman.freebsd.org> <200809181024.35437.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18Sep, 2008, at 16:24 , John Baldwin wrote: > On Thursday 18 September 2008 08:12:34 am SXren Schmidt wrote: >> sos 2008-09-18 12:12:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h >> Log: >> SVN rev 183141 on 2008-09-18 12:12:34Z by sos >> >> Cleanup the AHCI code a bit. >> Add suspend/resume for AHCI, general methods added. >> >> Inspired by: Andrey V. Elsukov > > Oo! I have suspend/resume for ICH then that fix my laptop at > www.freebsd.org/~jhb/patches/ata_resume.patch. These count on being > able to > have some controller-specific data in the softc for holding state > across > suspend/resume. However, I'm glad to see you are now ok with having > real > suspend/resume methods. Sure, but this needs more work in the sense that the chipinit/allocate code needs to be sorted out so resume can get the chipset back into shape without reallocating resources. If this is done properly it can be generically used on all chipsets wihtout the need for suspend/ resume code for each and every chipset. These new hook should be used for just that, not for kludging in all kinds of crap everywhere, its *not* needed in any but a few special cases. Anyhow as is evident I dont have much time currently and I see that things are getting somewhat out of control, so my opinion is just that :) -Søren -Søren > > > -- > John Baldwin > -Søren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45929AC0-E324-4CE5-962B-DEDFA9BD173C>