From owner-freebsd-gnome@FreeBSD.ORG  Fri Feb 25 07:56:15 2005
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: freebsd-gnome@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 49A0A16A4CE; Fri, 25 Feb 2005 07:56:15 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2B56F43D45; Fri, 25 Feb 2005 07:56:15 +0000 (GMT)
	(envelope-from marcus@FreeBSD.org)
Received: from freefall.freebsd.org (marcus@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1P7uFtL023937;
	Fri, 25 Feb 2005 07:56:15 GMT
	(envelope-from marcus@freefall.freebsd.org)
Received: (from marcus@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1P7uEn0023933;
	Fri, 25 Feb 2005 07:56:14 GMT
	(envelope-from marcus)
Date: Fri, 25 Feb 2005 07:56:14 GMT
From: Joe Marcus Clarke <marcus@FreeBSD.org>
Message-Id: <200502250756.j1P7uEn0023933@freefall.freebsd.org>
To: josemi@freebsd.jazztel.es, marcus@FreeBSD.org, gnome@FreeBSD.org
Subject: Re: ports/75816: [PATCH] www/firefox: new mozilla.sh and package
	script
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Feb 2005 07:56:15 -0000

Synopsis: [PATCH] www/firefox: new mozilla.sh and package script

State-Changed-From-To: open->closed
State-Changed-By: marcus
State-Changed-When: Fri Feb 25 07:52:11 GMT 2005
State-Changed-Why: 
I've committed some of this.  What I didn't commit was the PIS work.  While
the framework might be there to embed RC scripts into Mozilla and Firefox,
I don't think this is the right place to add sound server support.
I don't want to get bogged down in a lot of local scripts that make these ports
unsupportable, or in violation of our license agreement with Mozilla.

As for your pkg-[de]install work, I didn't see a real advantage of moving
some of these things out into scripts.  Plus, it looks like your pkg-deinstall
would nuke all of browser_plugins.

The rest of patches looked okay, and were merged.  In the future, please do
all diffs frome one level above the directory in question.  For example:

diff -ruN firefox.orig firefox

This makes patching much easier.  Also, please don't submit diffs against
CVS versions.  If a new version hasn't been released, either wait, or submit
the diff against the current version in the ports tree.  Thanks.

http://www.freebsd.org/cgi/query-pr.cgi?pr=75816