From owner-freebsd-scsi@FreeBSD.ORG  Thu Mar  1 17:27:36 2007
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
X-Original-To: freebsd-scsi@FreeBSD.ORG
Delivered-To: freebsd-scsi@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 06B3216A401;
	Thu,  1 Mar 2007 17:27:36 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.freebsd.org (Postfix) with ESMTP id AFC5613C481;
	Thu,  1 Mar 2007 17:27:35 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from scott-longs-computer.local (phobos.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id l21HRTmo057347;
	Thu, 1 Mar 2007 10:27:34 -0700 (MST)
	(envelope-from scottl@samsco.org)
Message-ID: <45E70CF5.10500@samsco.org>
Date: Thu, 01 Mar 2007 10:27:17 -0700
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US;
	rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1
MIME-Version: 1.0
To: Thomas Quinot <thomas@FreeBSD.ORG>
References: <20070225193802.GA32605@melamine.cuivre.fr.eu.org>
	<45E5F730.5070900@samsco.org>
	<20070228230339.GA77452@melamine.cuivre.fr.eu.org>
In-Reply-To: <20070228230339.GA77452@melamine.cuivre.fr.eu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]);
	Thu, 01 Mar 2007 10:27:34 -0700 (MST)
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: freebsd-scsi@FreeBSD.ORG
Subject: Re: xpt_done() and Giant?
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Mar 2007 17:27:36 -0000

Thomas Quinot wrote:
> * Scott Long, 2007-02-28 :
> 
>> I overlooked this, sorry.  Can you survive with it as it is for now?
> 
> Well, the current situation has been current for quite some time, so I
> think I can survive it :-)
> 
> On the other hand, the ATAPI/CAM interrupt routine runs outside of Giant
> and calls xpt_done (and also calls CAM_DEBUGGED itself), and it would be
> nice if CAMDEBUG worked with it. Is there any compelling reason for
> having GIANT_REQUIRED in xpt_path_comp? The only case I can see this as
> useful is when called in the context of CAM_DEBUG or CAM_DEBUGGED, to
> protect against a concurrent update of cam_dpath, but this really looks
> to me like a really tiny corner case.
> 
> Thomas.
> 

Full locking will be going into CAM soon, making this moot.

Scott