From owner-freebsd-commit Mon May 15 06:28:50 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00684 for commit-outgoing; Mon, 15 May 1995 06:28:50 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00665 for cvs-usrbin-outgoing; Mon, 15 May 1995 06:28:47 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id GAA00648 ; Mon, 15 May 1995 06:28:29 -0700 Received: by sequent.kiae.su id AA15408 (5.65.kiae-2 ); Mon, 15 May 1995 17:26:03 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Mon, 15 May 95 17:26:03 +0400 Received: (from ache@localhost) by astral.msk.su (8.6.8/8.6.6) id RAA00644; Mon, 15 May 1995 17:15:42 +0400 To: "Rodney W. Grimes" Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com References: <199505150656.XAA05295@gndrsh.aac.dev.com> In-Reply-To: <199505150656.XAA05295@gndrsh.aac.dev.com>; from "Rodney W. Grimes" at Sun, 14 May 1995 23:56:43 -0700 (PDT) Message-Id: Organization: Olahm Ha-Yetzirah Date: Mon, 15 May 1995 17:15:42 +0400 (MSD) X-Mailer: Mail/@ [v2.35 FreeBSD] From: "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Lines: 37 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1591 Sender: commit-owner@FreeBSD.org Precedence: bulk In message <199505150656.XAA05295@gndrsh.aac.dev.com> Rodney W. Grimes writes: >> >> ache 95/05/14 17:03:33 >> >> Modified: usr.bin/rpcgen rpc_parse.c >> Log: >> End of listcan be not marked, fix it >> Submitted by: Kai Vorma >I would really like to see commits being review at this stage of the >game. Even Jordan, David, myself, and PHK are having almost all of >our work reviewed by 1 if not 2 other folks. >I saw this report come in, though about it, and basically decided it >was not ``critical enough'' to fix at this time in the game give the >risk factor we are operating under. >Since you may know more about the rpc code, I will let this patch >stand for now, but please, let's all get every thing we do from here >until the code FREEZE is lifted reviewed by someone else after we >think it looks like a valid thing to be done. Rod, previously you write different things: only kernel and /usr/src/Makefile targets commits must be reviewd by 2 or more peoples (just read your announce), it is bad tone to change policy on the fly. I am smart enough to not commit suspicious thing at this stage or conslut with others about suspicious things. About this patch: I carefully check code flow and find that old code is definitely broken. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849