Date: Mon, 3 May 2004 10:09:53 +0200 From: Roman Neuhauser <neuhauser@chello.cz> To: Kris Kennaway <kris@obsecurity.org> Cc: freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: [PATCH] small speedups in Mk/bsd.port.mk Message-ID: <20040503080953.GA12341@isis.wad.cz> In-Reply-To: <20040503065209.GA92943@xor.obsecurity.org> References: <20040502050806.C12FB177CB@sirius.firepipe.net> <20040502070355.GA345@isis.wad.cz> <20040503065209.GA92943@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
# kris@obsecurity.org / 2004-05-02 23:52:09 -0700:
> On Sun, May 02, 2004 at 09:03:55AM +0200, Roman Neuhauser wrote:
>
> > Hrmph, right, dot is just one of regexp metacharacters.
> > This version uses plain string comparisons in DISTINFO_SIZE_AWK and
> > DISTINFO_CKSUM_AWK.
> >
> > Thanks again for testing! This would have taken weeks if I submitted
> > the patch right away.
>
> But that's why you should always test patches thoroughly before
> submitting them, right? ;-)
Yes, and I didn't mean to imply anything except that dealing with
portmgr@ is slow business.
As I said, my box has cooling problems, e. g. it couldn't finish two
consecutive builds of mod_php4 yesterday. Plus, testing can't prove
absence of bugs, and I of course tested all changes, but missed some
things, like the fact that there are more RE metacharacters than
just the dot. That's what public testing is good for, right? :)
BTW any progress with ports/40699? Average response time from
portmgr@ 7 months, and it's been suspended ("the patch doesn't apply
anymore"; no wonder two years after it's been submitted :) for more
than month despite three new versions of the patch?
--
If you cc me or remove the list(s) completely I'll most likely ignore
your message. see http://www.eyrie.org./~eagle/faqs/questions.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040503080953.GA12341>