From owner-freebsd-current@FreeBSD.ORG Thu Nov 12 01:55:50 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C36AF106566C; Thu, 12 Nov 2009 01:55:50 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 107F88FC14; Thu, 12 Nov 2009 01:55:49 +0000 (UTC) Received: from [10.242.164.77] (166-205-130-135.mobile.mymmode.com [166.205.130.135] (may be forged)) (authenticated bits=0) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id nAC1tYb1093070; Wed, 11 Nov 2009 18:55:44 -0700 (MST) (envelope-from scottl@samsco.org) References: <3bbf2fe10911060643g60079e31y7679b32dac670fd8@mail.gmail.com> <4AFAEE89.3020009@scsiguy.com> <3bbf2fe10911111746g48c8fb82r74744dffedf49758@mail.gmail.com> Message-Id: From: Scott Long To: Attilio Rao In-Reply-To: <3bbf2fe10911111746g48c8fb82r74744dffedf49758@mail.gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: iPhone Mail (7C144) Mime-Version: 1.0 (iPhone Mail 7C144) Date: Wed, 11 Nov 2009 18:55:25 -0700 X-Spam-Status: No, score=-2.6 required=3.8 tests=BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: "gibbs@freebsd.org" , "freebsd-current@freebsd.org" , Scott Long , Ed Maste Subject: Re: [PATCH] Adding sysctl for errors statistics to ahd(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2009 01:55:50 -0000 I don't think that there was a specific mention of newbus. I actually sees storage stats being the domain of either CAM or GEOM, and far too specific for newbus. Scott Sent from my iPhone On Nov 11, 2009, at 6:46 PM, Attilio Rao wrote: > 2009/11/11 Justin T. Gibbs : >> On 11/6/2009 7:43 AM, Attilio Rao wrote: >>> This patch introduces some mechanisms for collecting informations on >>> errors frequency and debugging (and relative sysctls for printing >>> them >>> out) for the ahd(4) driver: >>> http://www.freebsd.org/~attilio/Sandvine/STABLE_8/ahd/ahd-current2.diff >>> >>> The usage of array for sysctls is a bit too paranoid but it allows >>> for >>> further extendibility of the code and doesn't loose of cleaness. >>> This code has been contributed back by Sandvine Incorporated with >>> some >>> cleanups. >>> Please review. >>> >>> Thanks, >>> Attilio >> >> In general, I think the patch is fine. It violates the existing >> style >> of the driver in some places (e.g. the aic7xxx drivers wrap function >> arguments to the opening '(' not to a 4 space indent), which should >> probably be addressed so the code remains consistent. > > Sorry, I cannot find where these existing style breakage happens, > could you be a bit more precise? > (I just found an un-sorted header introduction in aic79xx.h that I > will fix). > > Anyways, your idea about a generalized interface in newbus for > handling that is not bad and as long as I'm planning some works in > this area I can add this item to the TODO list. > > Thanks, > Attilio > > > -- > Peace can only be achieved by understanding - A. Einstein