From owner-svn-src-projects@FreeBSD.ORG Fri Nov 20 15:13:52 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12927106566B; Fri, 20 Nov 2009 15:13:52 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from agogare.doit.wisc.edu (agogare.doit.wisc.edu [144.92.197.211]) by mx1.freebsd.org (Postfix) with ESMTP id D73708FC08; Fri, 20 Nov 2009 15:13:51 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=ISO-8859-1; format=flowed Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7.0-5.01 32bit (built Feb 19 2009)) id <0KTE00A02YB3LQ00@smtpauth2.wiscmail.wisc.edu>; Fri, 20 Nov 2009 09:13:51 -0600 (CST) Received: from comporellon.tachypleus.net (adsl-75-50-88-113.dsl.mdsnwi.sbcglobal.net [75.50.88.113]) by smtpauth2.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7.0-5.01 32bit (built Feb 19 2009)) with ESMTPSA id <0KTE00GKRYB1MS70@smtpauth2.wiscmail.wisc.edu>; Fri, 20 Nov 2009 09:13:50 -0600 (CST) Date: Fri, 20 Nov 2009 09:13:49 -0600 From: Nathan Whitehorn In-reply-to: <20091120184250.O13158@delplex.bde.org> To: Bruce Evans Message-id: <4B06B22D.60607@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=75.50.88.113 X-Spam-PmxInfo: Server=avs-14, Version=5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2009.11.20.150318, SenderIP=75.50.88.113 References: <200911190120.nAJ1KGBA089661@svn.freebsd.org> <20091119194149.L12648@delplex.bde.org> <86ws1m647w.fsf@ds4.des.no> <20091120184250.O13158@delplex.bde.org> User-Agent: Thunderbird 2.0.0.23 (X11/20090905) Cc: svn-src-projects@freebsd.org, =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= , src-committers@freebsd.org Subject: Re: svn commit: r199501 - projects/ppc64/sys/compat/freebsd32 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2009 15:13:52 -0000 Bruce Evans wrote: > On Thu, 19 Nov 2009, [utf-8] Dag-Erling Smørgrav wrote: > >> Bruce Evans writes: >>> This seems to have been generated from syscalls.master 199501, not the >>> claimed rev. Similarly for all other generated files. >> >> Common mistake: he regenerated them before committing. > > Too often made by new committers :-). And especially new committers seduced by the atomicity of multi-file commits in subversion... I'll do this in two steps when this eventually gets merged to head. Thanks for pointing it out! >> It would be neat[tm] if we had a post-commit hook to automatically >> regenerate these files... > > Maybe more should be generated on demand. Some of the generated syscall > files are special in being used by libc as well as kernels, but most > aren't. That would be really nice. A similar thing that would be nice would be if there were a post-commit hook that showed up at the same time to prevent you from modifying auto-generated files. -Nathan