Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 18 May 2011 20:52:52 +0000 (UTC)
From:      Ben Laurie <benl@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r222080 - head/usr.bin/rpcgen
Message-ID:  <201105182052.p4IKqqeV008068@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: benl
Date: Wed May 18 20:52:52 2011
New Revision: 222080
URL: http://svn.freebsd.org/changeset/base/222080

Log:
  Fix clang warnings.
  
  Note: these were actually bugs (printf with no format string).
  
  Approved by: philip (mentor)

Modified:
  head/usr.bin/rpcgen/rpc_hout.c
  head/usr.bin/rpcgen/rpc_svcout.c
  head/usr.bin/rpcgen/rpc_tblout.c

Modified: head/usr.bin/rpcgen/rpc_hout.c
==============================================================================
--- head/usr.bin/rpcgen/rpc_hout.c	Wed May 18 20:38:28 2011	(r222079)
+++ head/usr.bin/rpcgen/rpc_hout.c	Wed May 18 20:52:52 2011	(r222080)
@@ -500,7 +500,7 @@ pdeclaration(const char *name, declarati
 			break;
 		}
 	}
-	f_print(fout, separator);
+	fputs(separator, fout);
 }
 
 static int

Modified: head/usr.bin/rpcgen/rpc_svcout.c
==============================================================================
--- head/usr.bin/rpcgen/rpc_svcout.c	Wed May 18 20:38:28 2011	(r222079)
+++ head/usr.bin/rpcgen/rpc_svcout.c	Wed May 18 20:52:52 2011	(r222080)
@@ -349,7 +349,7 @@ write_real_program(definition *def)
 			f_print(fout, "(");
 			/* arg name */
 			if (proc->arg_num > 1)
-				f_print(fout, proc->args.argname);
+				fputs(proc->args.argname, fout);
 			else
 				ptype(proc->args.decls->decl.prefix,
 				      proc->args.decls->decl.type, 0);

Modified: head/usr.bin/rpcgen/rpc_tblout.c
==============================================================================
--- head/usr.bin/rpcgen/rpc_tblout.c	Wed May 18 20:38:28 2011	(r222079)
+++ head/usr.bin/rpcgen/rpc_tblout.c	Wed May 18 20:52:52 2011	(r222080)
@@ -103,7 +103,7 @@ write_table(definition *def)
 			expected = 0;
 		} else {
 			expected = 1;
-			f_print(fout, null_entry);
+			fputs(null_entry, fout);
 		}
 		for (proc = vp->procs; proc != NULL; proc = proc->next) {
 			current = atoi(proc->proc_num);
@@ -141,7 +141,7 @@ write_table(definition *def)
 		}
 
 		/* print the table trailer */
-		f_print(fout, tbl_end);
+		fputs(tbl_end, fout);
 		f_print(fout, tbl_nproc, progvers, progvers, progvers);
 	}
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105182052.p4IKqqeV008068>