From owner-freebsd-x11@FreeBSD.ORG  Tue May  8 23:59:27 2007
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
X-Original-To: freebsd-x11@freebsd.org
Delivered-To: freebsd-x11@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BD4E216A403
	for <freebsd-x11@freebsd.org>; Tue,  8 May 2007 23:59:27 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id AE09A13C448
	for <freebsd-x11@freebsd.org>; Tue,  8 May 2007 23:59:27 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id 9DE0D1A3C1A;
	Tue,  8 May 2007 17:00:09 -0700 (PDT)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 0872851408; Tue,  8 May 2007 19:59:26 -0400 (EDT)
Date: Tue, 8 May 2007 19:59:26 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Howard Goldstein <hg@queue.to>
Message-ID: <20070508235926.GA99040@xor.obsecurity.org>
References: <464100A7.5060200@queue.to>
	<20070508230300.GA98545@xor.obsecurity.org>
	<4641049F.70408@queue.to>
	<20070508232223.GA98863@xor.obsecurity.org>
	<464108DD.1040507@queue.to>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <464108DD.1040507@queue.to>
User-Agent: Mutt/1.4.2.2i
Cc: freebsd-x11@freebsd.org, kris@obsecurity.org
Subject: Re: x11/x11-libraries build
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 May 2007 23:59:27 -0000

On Tue, May 08, 2007 at 07:33:49PM -0400, Howard Goldstein wrote:
> Kris Kennaway wrote:
> >On Tue, May 08, 2007 at 07:15:43PM -0400, Howard Goldstein wrote:
> >>
> >>Kris Kennaway wrote:
> >>>On Tue, May 08, 2007 at 06:58:47PM -0400, Howard Goldstein wrote:
> >>>>Heads up?  Hmmm.... make clean works, but not make:
> >>>>
> >>>>cally:/usr/ports/x11/xorg-libraries# make -v
> >>>>*** Error code 1
> >>>>
> >>>>Stop in /usr/ports/x11/xorg-libraries.
> >>>>cally:/usr/ports/x11/xorg-libraries#
> >>>>
> >>>>
> >>>>On a system with no /usr/X11R6 at all, something in the following bits 
> >>>>hoses the build when those vars are not defined:
> >>>>
> >>>>.if !defined(XORG_UPGRADE) && !defined(PACKAGE_BUILDING)
> >>>>pre-everything::
> >>>>       @test -d /usr/X11R6 && echo "Read ${PORTSDIR}/UPDATING for the 
> >>>>procedure to upgrade to xorg 7.2." && ${FALSE}
> >>>>.endif
> >>>Did you try reading the text you quoted?
> >>Yes.  Do you know why it's failing with that output, is it because there 
> >>is no /usr/X11R6? Keep in mind this is on a system that's been tracking 
> >>git for months.
> >
> >Yes, see ${PORTSDIR}/UPDATING.
> 
> Perhaps I'm not understanding your problem with my post.   Is the 
> argument to the echo supposed to display on this failure, or, is it 
> supposed to fail displaying "*** Error code 1" without any further 
> explanation which is what I'm seeing here?

It is supposed to break if /usr/X11R6 is not a symlink.  So I guess it
should be

@test -L /usr/X11R6 || ( echo "Read ${PORTSDIR}/UPDATING for the procedure to upgrade to xorg 7.2." && /usr/bin/false )

Kris