From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 18:45:14 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 820291065672; Wed, 7 Mar 2012 18:45:14 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id AEABB8FC13; Wed, 7 Mar 2012 18:45:12 +0000 (UTC) Received: by werl4 with SMTP id l4so5281850wer.13 for ; Wed, 07 Mar 2012 10:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=vZJLp3zUzmD+Cur6UNk7ly3yxIzO5jTF6+XWtELSo6c=; b=T/0wT1WW+gBoH2FxCbaHNAFZ40F/NR2w0NJaXEGdnUuTLv/iIG2rsCD/8HXwzDuE4u ghWSV1Fa+Dg25+y2MbuxO+VCX9LF2hg5G1w+JPurvylNPVYzIowx85ptuYGJLlXdUPJ7 WW8GzHG8SDjQizn77RHlBH3TPJmTuQ7Q7spvjYIqYEeX7Bok7Mlq/4SHEpWH6fJB0FlR mDizAUfkoSNSRQM6RUiub8HoEhyqi5cTTS32ueddil98S1wZv+keY4Mq/UqRJzA+y7fH 9SAZDvoGQ8fXPEupZhTwdHyJzp6mQ/oXyGG325AtgGuJ0FKYLwfVIymokQKDC2Q+WwlC QBUQ== MIME-Version: 1.0 Received: by 10.180.96.8 with SMTP id do8mr28227482wib.21.1331145911774; Wed, 07 Mar 2012 10:45:11 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.198.81 with HTTP; Wed, 7 Mar 2012 10:45:11 -0800 (PST) In-Reply-To: <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> References: <201203052314.22050.bschmidt@freebsd.org> <20120307.023046.27956263.iwasaki@jp.FreeBSD.org> <201203062005.15276.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> Date: Wed, 7 Mar 2012 10:45:11 -0800 X-Google-Sender-Auth: PK0IEVcb8RFMaOC6Pdp60IJOZaE Message-ID: From: Adrian Chadd To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 18:45:14 -0000 Hi, I'd rather you didn't commit iwi_update_mcast() unless you absolutely know that the NIC doesn't need to be notified of multicast group membership changes. If so, please commit that as a separate fix. I'll look at iwi later and give you feedback on that particular change. Thanks for chasing this down! Adrian