Date: Wed, 27 Nov 2024 16:25:29 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 283006] devel/libgit2: SSH option does nothing Message-ID: <bug-283006-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283006 Bug ID: 283006 Summary: devel/libgit2: SSH option does nothing Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: mfechner@FreeBSD.org Reporter: ahktenzero+freebsd@mohorovi.cc Flags: maintainer-feedback?(mfechner@FreeBSD.org) Assignee: mfechner@FreeBSD.org Created attachment 255494 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D255494&action= =3Dedit Patch for libgit2 Makefile After some upgrades, noticed that my Salt masters using gitfs and git_pillar were unable to fetch anything from the remote repositories I had configured. After fixing some breakage in Salt due to changes in pygit2 I found I was l= eft with an error indicating that libgit2 was missing SSH support. I tested it outside of Salt with a small Python script and got the same result. This was surprising as I knew I had the SSH support enabled in the port (and it's on= by default), checking the installed libgit2 I found it wasn't linked against libssh2.=20 Dug into it some more, the option to enable SSH support was getting passed = to CMake during the port build but wasn't having any effect. Looking at the RE= ADME for libssh2, the USE_SSH option is now a choice of libssh2, extern, ON (equivalent to libssh2) or OFF, so setting it with '-DUSE_SSH:BOOL=3DON' wa= sn't working. Also noticed that the THREADSAFE option isn't present in the CMake= file any more and just produces an error during the build.=20 Patch to correct handling for the SSH option and remove the unused THREADSA= FE option is attached. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-283006-7788>