From nobody Tue Feb 24 03:10:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKjQX1VQMz6Sqfk; Tue, 24 Feb 2026 03:10:28 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKjQX0xk4z49NY; Tue, 24 Feb 2026 03:10:28 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771902628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0f3RCcTn8CfxeHOw3LQjbvIBEztCj1FLBJ+wzLX+JCg=; b=CfEpK4sdvo6Vf+oM3/wUmqiZhV/lQuYZ9v5CEfVcyk2QJqClNK9hguh/9PAbOa+Vy4lG8O ky8qMLx0ULZ94b+yKiQ41/B20+97C5D94xIJF6GUVBQoyygx4lwlhfWTBibyPSBocAm1/m 06tS1bofuQVHNac5b14bBJQ+LW1TcAtcL/Q0ZQybQF38idLCveBorEx2g3fNn0b3p4yNmr /OHTWgVCt8leWe4vBai6rYETPdDNECB2ltw14jMVXZFtiaalDQE+HMhEJD1uwIeB0IYbN9 dei2dBEOekZM3Cq+EPljocjDvkG7xDt01Y/xcRwOqMlJkoOyUBMKobD0EQ3D2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771902628; a=rsa-sha256; cv=none; b=Pug6X6QQRR3hLqbHPi+4uxf0sUMWWk1C7eC5r9d3IDIUQSIPScSIBBeJSuDLgZL1pIBURt +3apYmDx/v6LS8mBjSccq7nvWAi5pkloCmgCwfExpzG4v9GNpKtzFWRjDlEfxsxxFyLc18 Uf+xe5lhsRg0G6X1iOCJfR2HnS+4uWO7CHm2L0atYyDnSR9eN2iyQ0jxDDN9b21tI3jiqG xyNKOLPIoYDsoXQPGs62ezaLLkNXC2Db7NEmPk8NYupmbpjWD+yJG3Y/L3eNR278zbHkTN ShhJleQi0n/dsU8hejVsuN/Qv/ANZW9cEArFV353ifIDf8LcQKo1p5me9P+yuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771902628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0f3RCcTn8CfxeHOw3LQjbvIBEztCj1FLBJ+wzLX+JCg=; b=G9nz/bNYx5Px0Bf5VH1hMFAktZan7WhcCcsQdM9DQG7nnlLbcyjxCdqVAeJfL2l2xSBuwx eS3ydkbhU9mIWMiXRavspA23C/j6dg5mXWY3gRdicX8M/XY4FHUnGanmwu2wziWMMS5OFM VG0wsJauCJsUrOGI3dlxGc1LGt4urfYPB6b3XHnZEEapne3yKxEcug5F8i3rJUIRtLCZcF Xiv4QCqj8P6Wb9XmnCNsTiUYBgz/D5Zyqs4RDuUttY/2cahT/iBaqe/Cf7CTiqGfkOsZI7 ucbVF8C8poAyPcD64I5w6DE6iMszfdXczMWzviasIVZMKQQkhuOXf1ht29tTOw== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fKjQW4T8RzJBt; Tue, 24 Feb 2026 03:10:27 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: Date: Mon, 23 Feb 2026 21:10:24 -0600 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 0d3652f67d24 - main - sched_shim: Drop the no-ifunc case To: Mitchell Horne , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, Konstantin Belousov References: <6984c635.1e072.359146aa@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: <6984c635.1e072.359146aa@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/5/26 10:32, Mitchell Horne wrote: > The branch main has been updated by mhorne: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0d3652f67d246348e2c017205c6782caf4484449 > > commit 0d3652f67d246348e2c017205c6782caf4484449 > Author: Mitchell Horne > AuthorDate: 2026-02-05 16:12:03 +0000 > Commit: Mitchell Horne > CommitDate: 2026-02-05 16:32:16 +0000 > > sched_shim: Drop the no-ifunc case > > Now all architectures support kernel ifunc resolvers. Therefore, the > alternate implementation can be removed. > > Reviewed by: kib > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D55114 > --- > sys/kern/sched_shim.c | 8 -------- > 1 file changed, 8 deletions(-) > Hi, I'm trying to mentally reconcile the commit message with the diff... shouldn't we have kept the `DEFINE_IFUNC` version if all architectures now support ifunc resolvers? To the naked eye it looks like we removed the ifunc bits instead of the non-ifunc bits. Thanks, Kyle Evans > diff --git a/sys/kern/sched_shim.c b/sys/kern/sched_shim.c > index 83e4412494d3..2b1dcecda433 100644 > --- a/sys/kern/sched_shim.c > +++ b/sys/kern/sched_shim.c > @@ -22,20 +22,12 @@ > > const struct sched_instance *active_sched; > > -#ifndef __DO_NOT_HAVE_SYS_IFUNCS > -#define __DEFINE_SHIM(__m, __r, __n, __p, __a) \ > - DEFINE_IFUNC(, __r, __n, __p) \ > - { \ > - return (active_sched->__m); \ > - } > -#else > #define __DEFINE_SHIM(__m, __r, __n, __p, __a) \ > __r \ > __n __p \ > { \ > return (active_sched->__m __a); \ > } > -#endif > #define DEFINE_SHIM0(__m, __r, __n) \ > __DEFINE_SHIM(__m, __r, __n, (void), ()) > #define DEFINE_SHIM1(__m, __r, __n, __t1, __a1) \ >