From owner-freebsd-java@FreeBSD.ORG Wed May 12 10:55:33 2004 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C8BB16A4F3 for ; Wed, 12 May 2004 10:55:33 -0700 (PDT) Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr [139.124.41.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5906543D39 for ; Wed, 12 May 2004 10:55:31 -0700 (PDT) (envelope-from herve.quiroz@esil.univ-mrs.fr) Received: from arabica.esil.univ-mrs.fr (localhost.esil.univ-mrs.fr [127.0.0.1])i4CHtUa4052531 for ; Wed, 12 May 2004 19:55:30 +0200 (CEST) (envelope-from herve.quiroz@esil.univ-mrs.fr) Received: (from rv@localhost) by arabica.esil.univ-mrs.fr (8.12.10/8.12.10/Submit) id i4CHtT15052530 for java@FreeBSD.org; Wed, 12 May 2004 19:55:29 +0200 (CEST) (envelope-from herve.quiroz@esil.univ-mrs.fr) X-Authentication-Warning: arabica.esil.univ-mrs.fr: rv set sender to herve.quiroz@esil.univ-mrs.fr using -f Date: Wed, 12 May 2004 19:55:29 +0200 From: Herve Quiroz To: java@FreeBSD.org Message-ID: <20040512175529.GA52412@arabica.esil.univ-mrs.fr> Mail-Followup-To: java@FreeBSD.org References: <200405121310.i4CDAUY3033287@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200405121310.i4CDAUY3033287@freefall.freebsd.org> User-Agent: Mutt/1.4.2.1i Subject: Re: ports/66342: [PATCH] fix ECHO_MSG breakage in java ports X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2004 17:55:33 -0000 On Wed, May 12, 2004 at 06:10:30AM -0700, Roman Neuhauser wrote: > # herve.quiroz@esil.univ-mrs.fr / 2004-05-12 12:33:39 +0200: > > > > http://www.freshports.org/ports-ignore.php > > what kind of problem? you don't tell me what I should be looking for. > Sorry for that. For instance if you look at devel/ZendOptimizer: ZendOptimizer 2.5.1-1 / devel IGNORE: :\n Because of licensing restrictions, you must fetch the source distribution\n manually.\n Please access http://www.zend.com/store/free_download.php?pid=13\n with a web browser, read the license and click the \"I ACCEPT\" button.\n Download the source file, ZendOptimizer-2.5.1-FreeBSD4.0-i386.tar.gz,\n and place it in /usr/home/dan/ports/distfiles.\n You see the '\n' characters are in the output. > > - The first one is the "correct" regular expression but it doesn't work > > (that's why it is commented). > > right. you can't use the "\n" escape in replacement in the s command. > When I invoke sed from command-line (thus not from make) it works anyway. > > - The second is some kind of cheat, replacing '\n' by '%' in the regular > > expression, and then filtering through tr(1) to produce 'n'. This is > > quite ugly if you ask me but it works. > > it breaks ports whose IGNORE variable contains %. > Indeed, that's an issue. If there's a way to get rid of tr(1), it should work anyway. > another problem is that the third subst, if it worked, would break > long lines inside words, and would not reflow the text, producing > short line overflows. Indeed. > moreover, this patch, goes against my recent push to reduce > unnecessary commands in ${PORTSDIR}/Mk/*, so I guess it's not > surprising I'm not terribly excited. You're right. Actually the only problem I see with your solution is the same as the existing one (the output at FreshPorts.org), so it's not a big issue. I did not say I disagree with your patch BTW, just wanted to know your opinion about "the other way"... It's probably more a problem with FreshPorts.org than the ports tree itself. Herve