From owner-freebsd-bugs  Sat Jan 13  6:18:48 2001
Delivered-To: freebsd-bugs@freebsd.org
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by hub.freebsd.org (Postfix) with ESMTP id 46D6037B404
	for <freebsd-bugs@FreeBSD.ORG>; Sat, 13 Jan 2001 06:18:28 -0800 (PST)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.9.3/8.9.3) id JAA75138;
	Sat, 13 Jan 2001 09:18:20 -0500 (EST)
	(envelope-from wollman)
Date: Sat, 13 Jan 2001 09:18:20 -0500 (EST)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Message-Id: <200101131418.JAA75138@khavrinen.lcs.mit.edu>
To: Samuel Tardieu <sam@inf.enst.fr>
Cc: freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/24271: dumpon should check its argument more
In-Reply-To: <2001-01-13-13-41-54+trackit+sam@inf.enst.fr>
References: <200101121610.f0CGA7a52473@freefall.freebsd.org>
	<20010113095245.A66238@wantadilla.lemis.com>
	<20010113004100.A12683@walton.maths.tcd.ie>
	<2001-01-13-13-41-54+trackit+sam@inf.enst.fr>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

<<On Sat, 13 Jan 2001 13:41:53 +0100, Samuel Tardieu <sam@inf.enst.fr> said:

> +		case 'f':
> +		  force = 1;
> +			break;

> +			(void)snprintf(special, MAXPATHLEN, "%s%s", _PATH_DEV, argv[0]);
> +			if (!setfsent ())

> +				if (!strcmp(fsp->fs_spec, special)) {
> +					if (!strcmp(fsp->fs_type, FSTAB_SW))

> +					errx(EX_USAGE,
> +							 "%s: -f required to use a %s partition",
> +							 special,
> +							 fsp->fs_vfstype);

> +			errx(EX_USAGE,
> +					 "%s: -f required unless using a declared swap partition",
> +					 special);

> +		"usage: dumpon [-f] [-v] special_file\n"

This patch introduces at least eleven new style bugs.

-GAWollman



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message