From owner-freebsd-current@FreeBSD.ORG Wed Nov 28 00:57:58 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B428716A417 for ; Wed, 28 Nov 2007 00:57:58 +0000 (UTC) (envelope-from chuckr@chuckr.org) Received: from mail3.sea5.speakeasy.net (mail3.sea5.speakeasy.net [69.17.117.5]) by mx1.freebsd.org (Postfix) with ESMTP id 9565113C458 for ; Wed, 28 Nov 2007 00:57:58 +0000 (UTC) (envelope-from chuckr@chuckr.org) Received: (qmail 1495 invoked from network); 28 Nov 2007 00:31:18 -0000 Received: from april.chuckr.org (chuckr@[66.92.151.30]) (envelope-sender ) by mail3.sea5.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 28 Nov 2007 00:31:18 -0000 Message-ID: <474CB657.2090403@chuckr.org> Date: Tue, 27 Nov 2007 19:29:11 -0500 From: Chuck Robey User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.9) Gecko/20071107 SeaMonkey/1.1.6 MIME-Version: 1.0 To: Sam Leffler References: <474CAB2D.4040406@uffner.com> <474CAFA4.6040403@errno.com> In-Reply-To: <474CAFA4.6040403@errno.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: 802.11 w/ WEP requires deftxkey explicitly set after 2007-08-24 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2007 00:57:58 -0000 Sam Leffler wrote: > Tom Uffner wrote: >> Last night when i updated my laptop from June 26's CURRENT to CURRENT >> as of a few days ago my wireless connection stopped working for no >> apparent reason. >> >> What was wrong became painfully obvious once I tracked the problem >> back to this commit: >> >> sam 2007-08-24 15:44:27 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/net80211 ieee80211_output.c >> Log: >> drop frames marked for encryption when no key is available >> >> Reviewed by: avatar >> Approved by: re (kensmith) >> Obtained from: madwifi >> >> Revision Changes Path >> 1.51 +1 -0 src/sys/net80211/ieee80211_output.c >> >> Up until this change i didn't need to set deftxkey, it seems to have >> defaulted to wepkey 1 which i did have set. It is an obvious workaround >> now, but a note in UPDATING would have saved me about 9 hours of reading >> commitlogs, building kernels and rebooting (on an old slow laptop). >> >> If it doesn't violate the standard, could we make deftxkey default to >> the lowest indexed WEP key that has been set? if not, could we mention >> it in UPDATING and/or ifconfig(8) lest it bite someone else. > > deftxkey has defaulted to an undefined state since 6.0. Perhaps you can > show the specific case that is a regression for you. Is that because some standard requires it? Masking the default value to be set to something that can't possibly work seems to be a pretty silly thing to do, unless some standard requires it. Needing compatibility with a previous error in FreeBSD only is not sufficient, following such a rule would invalidate all progress permanently, it must be compatibility with some standard like POSIX, and even there, we have (I believe) several instances where we deliberately refused to follow obvious silliness.