From owner-svn-src-all@freebsd.org Wed Jan 29 04:33:46 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 504F71B79F2; Wed, 29 Jan 2020 04:33:46 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 486rGL1Q12z46Jq; Wed, 29 Jan 2020 04:33:46 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2BA996933; Wed, 29 Jan 2020 04:33:46 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 00T4XkWI087271; Wed, 29 Jan 2020 04:33:46 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 00T4XkI8087270; Wed, 29 Jan 2020 04:33:46 GMT (envelope-from cem@FreeBSD.org) Message-Id: <202001290433.00T4XkI8087270@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: Conrad Meyer Date: Wed, 29 Jan 2020 04:33:46 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r357243 - head/lib/libpmc/pmu-events X-SVN-Group: head X-SVN-Commit-Author: cem X-SVN-Commit-Paths: head/lib/libpmc/pmu-events X-SVN-Commit-Revision: 357243 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jan 2020 04:33:46 -0000 Author: cem Date: Wed Jan 29 04:33:45 2020 New Revision: 357243 URL: https://svnweb.freebsd.org/changeset/base/357243 Log: libpmc: jevents: Go ahead and use snprintf(3) Reported by: Coverity CID: 1391362 Modified: head/lib/libpmc/pmu-events/jevents.c Modified: head/lib/libpmc/pmu-events/jevents.c ============================================================================== --- head/lib/libpmc/pmu-events/jevents.c Wed Jan 29 04:32:06 2020 (r357242) +++ head/lib/libpmc/pmu-events/jevents.c Wed Jan 29 04:33:45 2020 (r357243) @@ -921,7 +921,8 @@ is_leaf_dir(const char *fpath) char path[PATH_MAX]; struct stat st; - sprintf(path, "%s/%s", fpath, dir->d_name); + snprintf(path, sizeof(path), "%s/%s", fpath, + dir->d_name); if (stat(path, &st)) break; @@ -1080,10 +1081,6 @@ process_one_file(const char *fpath, const struct stat return err; } -#ifndef PATH_MAX -#define PATH_MAX 4096 -#endif - /* * Starting in directory 'start_dirname', find the "mapfile.csv" and * the set of JSON files for the architecture 'arch'. @@ -1128,7 +1125,7 @@ main(int argc, char *argv[]) return 2; } - sprintf(ldirname, "%s/%s", start_dirname, arch); + snprintf(ldirname, sizeof(ldirname), "%s/%s", start_dirname, arch); /* If architecture does not have any event lists, bail out */ if (stat(ldirname, &stbuf) < 0) {