From owner-freebsd-arch Tue Sep 5 15:16:40 2000 Delivered-To: freebsd-arch@freebsd.org Received: from gatekeeper.tsc.tdk.com (gatekeeper.tsc.tdk.com [207.113.159.21]) by hub.freebsd.org (Postfix) with ESMTP id 687B737B423; Tue, 5 Sep 2000 15:16:38 -0700 (PDT) Received: from imap.gv.tsc.tdk.com (imap.gv.tsc.tdk.com [192.168.241.198]) by gatekeeper.tsc.tdk.com (8.8.8/8.8.8) with ESMTP id PAA20611; Tue, 5 Sep 2000 15:16:31 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from salsa.gv.tsc.tdk.com (salsa.gv.tsc.tdk.com [192.168.241.194]) by imap.gv.tsc.tdk.com (8.9.3/8.9.3) with ESMTP id PAA21915; Tue, 5 Sep 2000 15:16:30 -0700 (PDT) (envelope-from Don.Lewis@tsc.tdk.com) Received: (from gdonl@localhost) by salsa.gv.tsc.tdk.com (8.8.5/8.8.5) id PAA25991; Tue, 5 Sep 2000 15:16:21 -0700 (PDT) From: Don Lewis Message-Id: <200009052216.PAA25991@salsa.gv.tsc.tdk.com> Date: Tue, 5 Sep 2000 15:16:21 -0700 In-Reply-To: References: X-Mailer: Mail User's Shell (7.2.6 beta(5) 10/07/98) To: Bruce Evans , Don Lewis Subject: Re: Request for review: restructuring of per-uid resource limits Cc: Robert Watson , freebsd-arch@FreeBSD.ORG Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sep 6, 5:11am, Bruce Evans wrote: } Subject: Re: Request for review: restructuring of per-uid resource limits } On Tue, 5 Sep 2000, Don Lewis wrote: } } > My patch has KASSERT checks that look for ui_sbsize or ui_proccnt going } > negative, or not being zero when freeing the uidinfo structure. I } > could be convinced to make this checks mandatory. } } I think sanity checks (if any are implemented) should be mandatory in } new code. Done and committed. } Perhaps there should be several levels of KASSERTs, with at } least one level where the sanity checks are not mandatory (like the } current default of INVARIANTS not defined). That sounds good to me. Having to change the sense of the test to convert between "if (...) panic" and KASSERT as well as the other syntax changes basically sucks. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message