From owner-freebsd-arch@FreeBSD.ORG Fri May 13 21:52:40 2005 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D36116A4CE; Fri, 13 May 2005 21:52:40 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC2A643D6B; Fri, 13 May 2005 21:52:39 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j4DLqawU002172; Fri, 13 May 2005 17:52:38 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <4284ED54.9010603@FreeBSD.org> References: <200410020349.i923nG8v021675@northstar.hetzel.org> <20041002052856.GE17792@nexus.dglawrence.com> <20041002233542.GL714@nexus.dglawrence.com> <421DAD8F.6000704@portaone.com> <4284D038.50805@FreeBSD.org> <4284D4BC.9070705@FreeBSD.org> <4284ED54.9010603@FreeBSD.org> Date: Fri, 13 May 2005 17:52:36 -0400 To: Maxim Sobolev From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.2 cc: Paul Saab cc: freebsd-arch@FreeBSD.org Subject: Re: Bug in #! processing - One More Time X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2005 21:52:40 -0000 At 9:09 PM +0300 5/13/05, Maxim Sobolev wrote: >Garance A Drosihn wrote: >> >>I should have done enough testing by Sunday evening to say >>something, one way or another. Sure. > >Good, since this issue has been taking too much time to fix. I'll admit to being guilty on that. >>Note that I'm not just "running this through buildworld". That's >>how all the previous changes were tested, too. I have a whole >>battery of tests that I've been slogging through. > >Well, I'd suggest you to put those tests into src/tools/regression, >to ensure that this won't be broken occasionally in the future. Well, there's some simply tests in ~gad/shellargs on the freefall.org machines. Copy the directory, 'make /tmp/shellargs', and then 'make run/tests'. These aren't quite in the right format for the standard regression-testing ideas, but they're in the ballpark. The main idea was to give me a way to check what *other* operating systems actually do with whatever is on the #!-line. The 'results' directory has the results from several hosts around here (@RPI). Linux, Solaris, AIX, IRIX. I also have a userland program written for testing imgact_shell.c itself, but that is a bit more bizarre. Still, it's what I felt I needed so I could do a lot of testing of perverse examples, without having to rebuild kernels and rebooting every 5 minutes. It also lets me test with triggering panics which kill the system, as had happened in some previous updates to imgact_shell. Not sure that program would make any sense in regression testing. Maybe if it was cleaned up a bit. Anyway, back to my testing... -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu