From owner-freebsd-current  Wed Jan 20 12:30:51 1999
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id MAA14320
          for freebsd-current-outgoing; Wed, 20 Jan 1999 12:30:51 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA14312
          for <current@FreeBSD.ORG>; Wed, 20 Jan 1999 12:30:49 -0800 (PST)
          (envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.2/8.9.1) id MAA06970;
	Wed, 20 Jan 1999 12:30:43 -0800 (PST)
	(envelope-from dillon)
Date: Wed, 20 Jan 1999 12:30:43 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199901202030.MAA06970@apollo.backplane.com>
To: Matthew Dillon <dillon@apollo.backplane.com>
Cc: Bjoern Fischer <bfischer@TechFak.Uni-Bielefeld.DE>, current@FreeBSD.ORG
Subject: Re: panic: vinvalbuf: dirty bufs (during reboot, several times)
References: <19990120073445.A402@titan.klemm.gtn.com> <199901200700.XAA76802@apollo.backplane.com> <19990120132700.A15521@voliere.TechFak.Uni-Bielefeld.DE> <199901201923.LAA05838@apollo.backplane.com>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

    (This is mainly for Luoqi, John, or David, or anyone who understands
    struct buf's and NFS).

    I see some other weirdness in bread() relating to NFS as well. 

int
bread(struct vnode * vp, daddr_t blkno, int size, struct ucred * cred,
    struct buf ** bpp)
{
        struct buf *bp;

        bp = getblk(vp, blkno, size, 0, 0);
        *bpp = bp;

        /* if not found in cache, do some I/O */
        if ((bp->b_flags & B_CACHE) == 0) {
                if (curproc != NULL)
                        curproc->p_stats->p_ru.ru_inblock++;
                bp->b_flags |= B_READ;
                bp->b_flags &= ~(B_DONE | B_ERROR | B_INVAL);
                if (bp->b_rcred == NOCRED) {
                        if (cred != NOCRED)
                                crhold(cred);
                        bp->b_rcred = cred;
                }
                vfs_busy_pages(bp, 0);
                VOP_STRATEGY(vp, bp);
                return (biowait(bp));
        }
        return (0);
}

    The question is:  Do we have to check for B_DELWRI here and flush the bp
    before we issue the read op?

						-Matt


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message