From owner-freebsd-toolchain@freebsd.org Thu Mar 24 23:17:10 2016 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DB4EADD9D3 for ; Thu, 24 Mar 2016 23:17:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 873F31CE4 for ; Thu, 24 Mar 2016 23:17:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 82ECAADD9D2; Thu, 24 Mar 2016 23:17:10 +0000 (UTC) Delivered-To: toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82946ADD9D1 for ; Thu, 24 Mar 2016 23:17:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A3B71CE3; Thu, 24 Mar 2016 23:17:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::e0f9:ae86:eb6f:2b6f] (unknown [IPv6:2001:7b8:3a7:0:e0f9:ae86:eb6f:2b6f]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C503F23914; Fri, 25 Mar 2016 00:17:06 +0100 (CET) Subject: Re: CXXSTD=c++11 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_6F95CD35-22A5-4E07-9FD0-89ABF4FF74A8"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.6b2 (ebbf3ef) From: Dimitry Andric In-Reply-To: <7B77010A-B377-4B1A-835A-D48F59E5290D@FreeBSD.org> Date: Fri, 25 Mar 2016 00:16:48 +0100 Cc: toolchain@FreeBSD.org Message-Id: References: <56F46BE0.7080909@FreeBSD.org> <43ABA5F3-60E0-4A29-9698-B345A3DA0A8B@FreeBSD.org> <56F46E1B.4010605@FreeBSD.org> <56F46F67.2000807@FreeBSD.org> <7B77010A-B377-4B1A-835A-D48F59E5290D@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2016 23:17:10 -0000 --Apple-Mail=_6F95CD35-22A5-4E07-9FD0-89ABF4FF74A8 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=windows-1252 On 24 Mar 2016, at 23:54, Dimitry Andric wrote: > > On 24 Mar 2016, at 23:51, Bryan Drewery wrote: ... >> It fails without -std=c++11 (there's more discussion in that link and in >> PR 205453). > > Yeah, I also commented on PR 205453 in the past, but I still don't > understand where the external gcc gets its _Static_assert macro from. > Or whether it gets it at all. Maybe we should place a hack for this in > sys/cdefs.h? We shouldn't litter contrib code with #ifdef GCC_VERSION > blocks. Hm, hacking around in cdefs.h also doesn't really help, because gcc refuses to recognize either _Static_assert or static_assert when it's not in C++11 mode. Reading back https://reviews.freebsd.org/D1390, I see that I originally wanted to avoid building libcxxrt with -std=c++11. This was so you could even build it with gcc 4.2.1 from base. However, it really doesn't make much sense to do so, and upstream libcxxrt simply uses static_assert directly, and requires -std=c++11. I will update the libcxxrt build to do so, probably tomorrow. -Dimitry --Apple-Mail=_6F95CD35-22A5-4E07-9FD0-89ABF4FF74A8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.29 iEYEARECAAYFAlb0dXIACgkQsF6jCi4glqOhuwCfZ1ezyu4FcS1tWRqOA1G/evMP nisAoO38mEZwNhA/aKPELbglsmcuBPY2 =N3SJ -----END PGP SIGNATURE----- --Apple-Mail=_6F95CD35-22A5-4E07-9FD0-89ABF4FF74A8--