From owner-freebsd-bugs@FreeBSD.ORG  Tue Feb 21 14:10:09 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A94DC16A420
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 21 Feb 2006 14:10:09 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7F49B43D64
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 21 Feb 2006 14:10:06 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1LEA529085836
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 21 Feb 2006 14:10:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1LEA5P6085835;
	Tue, 21 Feb 2006 14:10:05 GMT (envelope-from gnats)
Resent-Date: Tue, 21 Feb 2006 14:10:05 GMT
Resent-Message-Id: <200602211410.k1LEA5P6085835@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Martin Beran <mb@tns.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD0A716A420
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 21 Feb 2006 14:08:01 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6DE2643D53
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 21 Feb 2006 14:08:01 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k1LE809Z024361
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 21 Feb 2006 14:08:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k1LE80rW024360;
	Tue, 21 Feb 2006 14:08:00 GMT (envelope-from nobody)
Message-Id: <200602211408.k1LE80rW024360@www.freebsd.org>
Date: Tue, 21 Feb 2006 14:08:00 GMT
From: Martin Beran <mb@tns.cz>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: bin/93644: Wrong handling of 'return 1' in /bin/sh with 'set -e'
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Feb 2006 14:10:09 -0000


>Number:         93644
>Category:       bin
>Synopsis:       Wrong handling of 'return 1' in /bin/sh with 'set -e'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 21 14:10:05 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Martin Beran
>Release:        6.0-RELEASE-p4
>Organization:
Trusted Network Solutions, a.s.
>Environment:
FreeBSD mb.tns.cz 6.0-RELEASE-p4 FreeBSD 6.0-RELEASE-p4 #4: Fri Feb  3 12:09:35 CET 2006     root@mb.tns.cz:/usr/obj/usr/src/sys/MB  i386
>Description:
Shell /bin/sh terminates a script when a function returns with a nonzero return value and 'set -e' is in effect, even when the return value of the function is tested, e.g., by 'if'. This bug occurs only if return is not the last command in the function.
>How-To-Repeat:
#!/bin/sh -e
f() {
    return 1
    :
}
if f; then :; fi
echo END

I think this script should print "END", but is does not. It works as expected after changing function f to
f() {
    return 1
}
or
f() {
    return 1 || :
    :
}
>Fix:
              
>Release-Note:
>Audit-Trail:
>Unformatted: