From owner-freebsd-gnome@FreeBSD.ORG Sat Jun 12 01:40:03 2010 Return-Path: Delivered-To: gnome@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B2CE41065670 for ; Sat, 12 Jun 2010 01:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A2F3B8FC08 for ; Sat, 12 Jun 2010 01:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o5C1e36K071400 for ; Sat, 12 Jun 2010 01:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o5C1e3jq071399; Sat, 12 Jun 2010 01:40:03 GMT (envelope-from gnats) Date: Sat, 12 Jun 2010 01:40:03 GMT Message-Id: <201006120140.o5C1e3jq071399@freefall.freebsd.org> To: gnome@FreeBSD.org From: Nathan Whitehorn Cc: Subject: Re: ports/147699: [patch] powerpc64 support for x11-toolkits/gtk20 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Nathan Whitehorn List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 01:40:03 -0000 The following reply was made to PR ports/147699; it has been noted by GNATS. From: Nathan Whitehorn To: Koop Mast Cc: bug-followup@FreeBSD.org Subject: Re: ports/147699: [patch] powerpc64 support for x11-toolkits/gtk20 Date: Fri, 11 Jun 2010 19:35:13 -0500 On Fri, 11 Jun 2010 23:05:32 +0200 Koop Mast wrote: > Hello, > > Is the following part needed? Because it is also in bsd.port.mk:1208. > It is a bit double doing it again in the port. > > # Get the architecture > .if !defined(ARCH) > ARCH!= ${UNAME} -p > .endif > > -Koop > It does not seem so. I had just blindly copied the architecture detection code out of the xorg-server Makefile. You have to move the conditional until after the .include for it to work, though, since ARCH isn't defined before that. -Nathan