Date: Mon, 22 Nov 2010 15:38:50 +0100 (CET) From: Koop Mast <kwm@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/152480: [Patch] fix build of libffi with clang on amd64 Message-ID: <20101122143850.EDDA7107CE65@mail.rainbow-runner.nl> Resent-Message-ID: <201011221440.oAMEeC9t074765@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 152480
>Category: ports
>Synopsis: [Patch] fix build of libffi with clang on amd64
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 22 14:40:12 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Koop Mast
>Release: FreeBSD 8.1-RELEASE-p1 amd64
>Organization:
>Environment:
System: FreeBSD hermes.rainbow-runner.nl 8.1-RELEASE-p1 FreeBSD 8.1-RELEASE-p1 #3 r212995: Wed Sep 22 14:19:30 CEST 2010 root@hermes.rainbow-runner.nl:/var/obj/usr/src/sys/Hermes amd64
>Description:
$CFLAGS are redundant for compiling .s files.
GCC stays quiet, but Clang gives a warning of unused arguments.
The configure check greps for warning, so the check fails.
Remove $CFLAGS to clang doesn't emit the warnings.
Patch by Dimitry Andric <dim@FreeBSD.org>
>How-To-Repeat:
>Fix:
--- libffi-clang.diff begins here ---
Index: devel/libffi/files/patch-configure
===================================================================
RCS file: /home/pcvs/ports/devel/libffi/files/patch-configure,v
retrieving revision 1.1
diff -a -u -r1.1 patch-configure
--- devel/libffi/files/patch-configure 18 Jul 2010 21:43:19 -0000 1.1
+++ devel/libffi/files/patch-configure 22 Nov 2010 14:07:36 -0000
@@ -1,5 +1,5 @@
---- configure.orig 2010-06-03 20:49:28.000000000 +0000
-+++ configure 2010-06-03 20:50:18.000000000 +0000
+--- configure.orig 2010-11-22 12:53:14.000000000 +0100
++++ configure 2010-11-22 12:53:26.000000000 +0100
@@ -12231,6 +12231,9 @@
powerpc-*-freebsd*)
TARGET=POWERPC_FREEBSD; TARGETDIR=powerpc
@@ -10,5 +10,12 @@
powerpc*-*-rtems*)
TARGET=POWERPC; TARGETDIR=powerpc
;;
-
-
+@@ -14484,7 +14487,7 @@
+
+ libffi_cv_as_x86_pcrel=yes
+ echo '.text; foo: nop; .data; .long foo-.; .text' > conftest.s
+- if $CC $CFLAGS -c conftest.s 2>&1 | grep -i warning > /dev/null; then
++ if $CC -c conftest.s 2>&1 | grep -i warning > /dev/null; then
+ libffi_cv_as_x86_pcrel=no
+ fi
+
--- libffi-clang.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101122143850.EDDA7107CE65>