From owner-freebsd-hackers@FreeBSD.ORG  Wed May 13 15:00:29 2015
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 048B8BB2;
 Wed, 13 May 2015 15:00:29 +0000 (UTC)
Received: from mail-ig0-x22d.google.com (mail-ig0-x22d.google.com
 [IPv6:2607:f8b0:4001:c05::22d])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C3F8D162E;
 Wed, 13 May 2015 15:00:28 +0000 (UTC)
Received: by igbsb11 with SMTP id sb11so47263072igb.0;
 Wed, 13 May 2015 08:00:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=1w7up1k5fXpJDHhqYuIG4cq6l26gTy4t2wCvP/Nb0h4=;
 b=uh02GinXcflYh6wIbRMoYIA5fZQjoOWTam8l+CF6Y0XF4/jSU4urIwvLC9sNSF+K+X
 M37E0lFIiAE+aWkYnR/4PbXYsirscQbv8h7IpiK1Kq4W+bVXXu6gp1xQe1ccNPLc5EMC
 k5n63QnJoO46rm0yj2mlG+JU+wDGnzsrm8dA1U4m2+GZvJnGNU1E78UEyQOtndzRiVLK
 yLAo7oG1yM4CTduqTsHgMnCCaQNG1rBDEA3DfkuBmDSJOI4FWjNM5sFnmBfMerNtqBA6
 kdBY59QNgFAj/hIXxEI6Ny7Ax9kgB1AbkFO1GrPuYzKgHrERlyfXJCYFA3eQaUvXDdhC
 uktg==
X-Received: by 10.42.20.197 with SMTP id h5mr9456566icb.22.1431529227992; Wed,
 13 May 2015 08:00:27 -0700 (PDT)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.48.3 with HTTP; Wed, 13 May 2015 08:00:07 -0700 (PDT)
In-Reply-To: <20150513070259.GA27935@vps.markoturk.info>
References: <20150513070259.GA27935@vps.markoturk.info>
From: Ed Maste <emaste@freebsd.org>
Date: Wed, 13 May 2015 11:00:07 -0400
X-Google-Sender-Auth: 38bah26lu6Q_5DPZPT1V6rF_cmQ
Message-ID: <CAPyFy2A2JDCW5=oRnJGRzGuaBpBViherxK6mzMddvXXKoa0Hog@mail.gmail.com>
Subject: Re: vt_core.c vt_is_cursor_in_area different behavior after r282823
To: Marko Turk <markoml@markoturk.info>
Cc: freebsd-stable stable <freebsd-stable@freebsd.org>, 
 "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 15:00:29 -0000

On 13 May 2015 at 03:02, Marko Turk <markoml@markoturk.info> wrote:
> Hi,
>
> after r282823, new vt_is_cursor_in_area is, in some cases, returning
> different values than the old function.
>
> For example:
> If (my + vd->vd_mcursor->height) is equal to (area->tr_begin.tp_row),
> old function will return 1 and new function will return 0.
>
> Is this intended behavior or is it a bug?

Thanks for the detailed look at the change! It's intentional -- when
they're equal the cursor rectangle and display area rectangle border
each other, but do not actually overlap. It doesn't hurt to return 1
in this case, it just results in some unnecessary drawing.