From owner-cvs-all  Tue Jan 12 13:26:21 1999
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id NAA13302
          for cvs-all-outgoing; Tue, 12 Jan 1999 13:26:21 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from whistle.com (s205m131.whistle.com [207.76.205.131])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA13283;
          Tue, 12 Jan 1999 13:26:11 -0800 (PST)
          (envelope-from archie@whistle.com)
Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id NAA17261; Tue, 12 Jan 1999 13:24:57 -0800 (PST)
Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0)
	id xma017257; Tue, 12 Jan 99 13:24:53 -0800
Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id NAA07208; Tue, 12 Jan 1999 13:24:53 -0800 (PST)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199901122124.NAA07208@bubba.whistle.com>
Subject: Re: cvs commit: src/sys/netinet ip_input.c
In-Reply-To: <199901121921.LAA05046@dingo.cdrom.com> from Mike Smith at "Jan 12, 99 11:21:31 am"
To: mike@smith.net.au (Mike Smith)
Date: Tue, 12 Jan 1999 13:24:53 -0800 (PST)
Cc: eivind@FreeBSD.ORG, luigi@labinfo.iet.unipi.it, cvs-committers@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL38 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Mike Smith writes:
> > Unless good counter-arguments spring forward, -Werror is going in
> > shortly, so tolerating the warnings is not an option.
> 
> -Werror is anal fluff.  I applaud it being the default for general 
> usage, but -Werror made working on NetBSD *extremely* difficult.  
> Stamping out warnings is desirable, but sometimes the crud in the code 
> required to do it is worse than the warning.

This is not a counter-argument, only a report from my personal
experience.

To me the gcc warnings are *essential* to producing bug-free code
in a timely manner. Therefore, getting to -Werror is a good goal.

While there are weird corner cases where a warning may be unavoidable,
gcc provides mechanisms to deal with these (like our __dead and __unused).

So IMHO it's pretty vanishingly rare that -Werror is impossible to achieve.

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message