From owner-cvs-src@FreeBSD.ORG Sat Oct 21 10:24:22 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A6F116A403; Sat, 21 Oct 2006 10:24:22 +0000 (UTC) (envelope-from Yuriy.Tsibizov@gfk.ru) Received: from mx.gfk.ru (mx.gfk.ru [84.21.231.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 314E343D5C; Sat, 21 Oct 2006 10:24:20 +0000 (GMT) (envelope-from Yuriy.Tsibizov@gfk.ru) Received: from ex.hhp.local by mx.gfk.ru (MDaemon PRO v9.0.5) with ESMTP id md50000579768.msg; Sat, 21 Oct 2006 14:23:26 +0400 Received: from dialup-chibis.gfk.ru ([10.0.6.45]) by ex.hhp.local with Microsoft SMTPSVC(6.0.3790.1830); Sat, 21 Oct 2006 14:23:18 +0400 Date: Sat, 21 Oct 2006 14:24:44 +0400 (MSD) From: Yuriy Tsibizov X-X-Sender: chibis@free.home.local To: John-Mark Gurney , Yuriy Tsibizov In-Reply-To: <200610202128.k9KLSBgo059305@repoman.freebsd.org> Message-ID: <20061021142416.G1198@free.home.local> References: <200610202128.k9KLSBgo059305@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-OriginalArrivalTime: 21 Oct 2006 10:23:19.0797 (UTC) FILETIME=[EDF62250:01C6F4FA] X-Spam-Processed: mx.gfk.ru, Sat, 21 Oct 2006 14:23:26 +0400 (not processed: message from valid local sender) X-MDRemoteIP: 10.0.0.30 X-Return-Path: Yuriy.Tsibizov@gfk.ru X-Envelope-From: Yuriy.Tsibizov@gfk.ru X-MDAV-Processed: mx.gfk.ru, Sat, 21 Oct 2006 14:23:26 +0400 Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2006 10:24:22 -0000 > jmg 2006-10-20 21:28:11 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pci pci.c > Log: > fix tab indentation for CP and RV... > > If the length is zero, catch this early, instead of making dflen go negative > and letting bad things happen... We also check to see if RV (checksum) is > 0, and handle that has a checksum failure... > > Properly handle checksum failures by not processing read-write VPD data, > and removing all the found read-only data... > > Tested by: oleg (dflen going negative) John-Mark, what 'bad things' will not happen? I see that commited patch differs from one you posted earlier on cvs-src which (possibly) caused my Realtek PCIE network card to change it's PCI id (as described in message to -current, under 'RE:ASUS U5F hangs during PCI bus probe' subject). Are there any possibility to check arguments of pci_read_vpd_reg to make shure it will write only in correct PCI configuration register? Yuriy. p.s. Please keep me in to/cc, I'm currently off-list.