From owner-freebsd-fs@FreeBSD.ORG Mon Sep 3 08:51:26 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA87A106566C for ; Mon, 3 Sep 2012 08:51:26 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.31.37]) by mx1.freebsd.org (Postfix) with ESMTP id 7A3EC8FC16 for ; Mon, 3 Sep 2012 08:51:26 +0000 (UTC) Received: from [78.35.150.55] (helo=fabiankeil.de) by smtprelay03.ispgateway.de with esmtpsa (SSLv3:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1T8SNK-0001kx-UE for freebsd-fs@freebsd.org; Mon, 03 Sep 2012 10:51:19 +0200 Date: Mon, 3 Sep 2012 10:45:25 +0200 From: Fabian Keil To: freebsd-fs@freebsd.org Message-ID: <20120903104525.531e5d3d@fabiankeil.de> In-Reply-To: <5044556C.3020208@shatow.net> References: <504428EB.4020702@shatow.net> <504430F9.8000105@shatow.net> <5044482D.90602@shatow.net> <5044556C.3020208@shatow.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/z7A1qHRzIKOAgt1D2bMG2FI"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 Subject: Re: Panic in zfs_freebsd_getattr -> zfs_fuid_table_load - avl_find() succeeded inside avl_add() [ACL, 9.1-PRERELEASE] [SOLVED] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2012 08:51:27 -0000 --Sig_/z7A1qHRzIKOAgt1D2bMG2FI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Bryan Drewery wrote: > On 9/3/2012 1:03 AM, Bryan Drewery wrote: > > On 9/2/2012 11:24 PM, Bryan Drewery wrote: > >>> On Sep 2, 2012 8:51 PM, "Bryan Drewery" >>> > wrote: > >>> > >>> Running 9.1-PRERELEASE currently. > >>> > >>> Just set this server up, imported the pool from OpenIndiana 151 I > >>> believe it was. > >>> > >>> When I access (simply `ls`) certain files/directories, the system > >>> panics. These files have ACL properties set on them from the Sola= ris > >>> system. > >>> > >>> This system has 32gb of ram and only 8gb swap setup, so I do not > >>> currently have a kernel core dump. It's also practically a produc= tion > >>> machine, so I do not have much leeway in testing on it. For the space issue setting debug.minidump and vfs.zfs.zio.exclude_metadata could help (if they aren't set already). > I've solved this and now have a working system. >=20 > r230454 [1] fixes this. It had a MFC of 1 week but never made it to > 9-STABLE. >=20 > Please MFC this! >=20 > OTOH, the change looks wrong, but I don't know enough to say that for > certain. >=20 >=20 > Why change kd_name to size 1, and then use strcpy(). Looks like an easy > overflow. >=20 > [1] http://lists.freebsd.org/pipermail/svn-src-head/2012-January/033707.h= tml Note that the size of the allocated buffer is sizeof(*kd) + strlen(domain), not just sizeof(*kd). Fabian --Sig_/z7A1qHRzIKOAgt1D2bMG2FI Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBEbikACgkQBYqIVf93VJ1ORQCglmhDuUv3+y7l9abJDD5ZT76p gy4AoJO11Y58ooMLPS7Br+EsO6ZnSkhQ =rrRy -----END PGP SIGNATURE----- --Sig_/z7A1qHRzIKOAgt1D2bMG2FI--