Date: Sat, 8 Jan 2011 13:21:59 -0500 (EST) From: Daniel Eischen <deischen@freebsd.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: rrs@freebsd.org, freebsd-current@freebsd.org Subject: Re: UDP checksum broken, -head and releng_8 Message-ID: <Pine.GSO.4.64.1101081320380.27326@sea.ntplx.net> In-Reply-To: <Pine.GSO.4.64.1101070640050.20933@sea.ntplx.net> References: <Pine.GSO.4.64.1101070412140.19838@sea.ntplx.net> <20110107103837.E14966@maildrop.int.zabbadoz.net> <Pine.GSO.4.64.1101070613200.20933@sea.ntplx.net> <Pine.GSO.4.64.1101070640050.20933@sea.ntplx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---559023410-959030623-1294510919=:27326 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Fri, 7 Jan 2011, Daniel Eischen wrote: > On Fri, 7 Jan 2011, Daniel Eischen wrote: > >> On Fri, 7 Jan 2011, Bjoern A. Zeeb wrote: >> >>> On Fri, 7 Jan 2011, Daniel Eischen wrote: >>> >>>> When sending multicast packets to a socket that is _not_ >>>> bound to the multicast address, this generates bad UDP >>>> checksums. This use to work and was broke sometime between >>>> the middle of October and late December as far as I can >>>> tell. >>> >>> My very best guess would be: r215110 >> >> It doesn't look very harmful, but I'll try backing it out. > > Backing this out seems to fix it. I'll have to test it > more after I get some sleep ;-) I've attached what may be a proper patch. Please review. I'd like to get this fixed in releng_8 too. -- DE ---559023410-959030623-1294510919=:27326 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=in_pcb.c.diff Content-Transfer-Encoding: BASE64 Content-ID: <Pine.GSO.4.64.1101081321590.27326@sea.ntplx.net> Content-Description: Content-Disposition: attachment; filename=in_pcb.c.diff SW5kZXg6IG5ldGluZXQvaW5fcGNiLmMNCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NCi0tLSBuZXRpbmV0L2luX3BjYi5jCShyZXZpc2lvbiAyMTY2OTApDQor KysgbmV0aW5ldC9pbl9wY2IuYwkod29ya2luZyBjb3B5KQ0KQEAgLTg3NCw2 ICs4NzQsNyBAQA0KIAkJfQ0KIAl9DQogCWlmIChsYWRkci5zX2FkZHIgPT0g SU5BRERSX0FOWSkgew0KKwkJZXJyb3IgPSBpbl9wY2JsYWRkcihpbnAsICZm YWRkciwgJmxhZGRyLCBjcmVkKTsNCiAJCS8qDQogCQkgKiBJZiB0aGUgZGVz dGluYXRpb24gYWRkcmVzcyBpcyBtdWx0aWNhc3QgYW5kIGFuIG91dGdvaW5n DQogCQkgKiBpbnRlcmZhY2UgaGFzIGJlZW4gc2V0IGFzIGEgbXVsdGljYXN0 IG9wdGlvbiwgdXNlIHRoZQ0KQEAgLTg5MywxNiArODk0LDE3IEBADQogCQkJ CQkJYnJlYWs7DQogCQkJCWlmIChpYSA9PSBOVUxMKSB7DQogCQkJCQlJTl9J RkFERFJfUlVOTE9DSygpOw0KLQkJCQkJcmV0dXJuIChFQUREUk5PVEFWQUlM KTsNCisJCQkJCWVycm9yID0gRUFERFJOT1RBVkFJTDsNCisJCQkJfSBlbHNl IHsNCisJCQkJCWxhZGRyID0gaWEtPmlhX2FkZHIuc2luX2FkZHI7DQorCQkJ CQlJTl9JRkFERFJfUlVOTE9DSygpOw0KKwkJCQkJLyogT3ZlcnJpZGUgZXJy b3IgZnJvbSBpbl9wY2JsYWRkcigpLiAqLw0KKwkJCQkJZXJyb3IgPSAwOw0K IAkJCQl9DQotCQkJCWxhZGRyID0gaWEtPmlhX2FkZHIuc2luX2FkZHI7DQot CQkJCUlOX0lGQUREUl9SVU5MT0NLKCk7DQogCQkJfQ0KLQkJfSBlbHNlIHsN Ci0JCQllcnJvciA9IGluX3BjYmxhZGRyKGlucCwgJmZhZGRyLCAmbGFkZHIs IGNyZWQpOw0KLQkJCWlmIChlcnJvcikgDQotCQkJCXJldHVybiAoZXJyb3Ip Ow0KIAkJfQ0KKwkJaWYgKGVycm9yKQ0KKwkJCXJldHVybiAoZXJyb3IpOw0K IAl9DQogCW9pbnAgPSBpbl9wY2Jsb29rdXBfaGFzaChpbnAtPmlucF9wY2Jp bmZvLCBmYWRkciwgZnBvcnQsIGxhZGRyLCBscG9ydCwNCiAJICAgIDAsIE5V TEwpOw0K ---559023410-959030623-1294510919=:27326--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.1101081320380.27326>