Date: Tue, 12 Mar 2019 08:02:59 +0000 From: Matthew Seaman <matthew@FreeBSD.org> To: koobs@FreeBSD.org, Koichiro Iwao <meta@FreeBSD.org> Cc: ports-committers@FreeBSD.org, python <python@FreeBSD.org> Subject: Re: right procedure committing changes to core ports? Message-ID: <f0bc14ad-34b5-ff25-0790-435c3114de96@FreeBSD.org> In-Reply-To: <0502b927-6c97-275b-64a6-91c9e6144dab@FreeBSD.org> References: <20190312013900.mt5s43wy7zjzoxga@icepick.vmeta.jp> <0502b927-6c97-275b-64a6-91c9e6144dab@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--nBbf1nlaXYqItrzhnrAqS8iWhNZOAbdRC
Content-Type: multipart/mixed; boundary="2HLEnm801Pn6rylKUrjLD5OVlPPiGVWZf";
protected-headers="v1"
From: Matthew Seaman <matthew@FreeBSD.org>
To: koobs@FreeBSD.org, Koichiro Iwao <meta@FreeBSD.org>
Cc: ports-committers@FreeBSD.org, python <python@FreeBSD.org>
Message-ID: <f0bc14ad-34b5-ff25-0790-435c3114de96@FreeBSD.org>
Subject: Re: right procedure committing changes to core ports?
References: <20190312013900.mt5s43wy7zjzoxga@icepick.vmeta.jp>
<0502b927-6c97-275b-64a6-91c9e6144dab@FreeBSD.org>
In-Reply-To: <0502b927-6c97-275b-64a6-91c9e6144dab@FreeBSD.org>
--2HLEnm801Pn6rylKUrjLD5OVlPPiGVWZf
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: quoted-printable
On 12/03/2019 07:50, Kubilay Kocak wrote:
> On 12/03/2019 1:39 am, Koichiro Iwao wrote:
>> Hi,
>>
>> I'm willing to commit this. It fixes lang/python27 to build with
>> libressl{,-devel} but it seems few people interested in that.
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234568
>>
>> I'd appreciate if someone tell me the right procedure committing chang=
es
>> to core ports such as lang/python*, lang/perl*.=C2=A0 I mean core port=
s are
>> important ports that affect almost all ports users.
>>
>> Do I have to get someone's approval to commit it?
>>
>=20
> Hi Koichiro,
>=20
> There's a few distinct issues in this:
>=20
> 1) Approval for python@ ports, in general: Yes they require python@
> approval as we're on the hook for QA/regressions/maintainership.
>=20
> For non-core ports (other than lang/python*, setuptools and a few other=
> important ports) commit by maintainer timeout *with complete QA* is of
> course fine.
>=20
> Unfortunately there's no way to codify a 'core/non-core' or other usefu=
l
> policy/maintainership distinctions by way of a MAINTAINER_POLICY or
> similar, so the difference between 'this port is super important and
> requires extra eyes/review' and 'we're just a fallback/defacto
> maintainer' is not apparent or obvious. I expect this is a similar issu=
e
> in other major porting teams (gnome, kde, ruby, et al) too.
>=20
> 2) The python build system is *notoriously* sensitive to changes,
> particularly with apparently simple CFLAGS, *FLAGS, environment changes=
=2E
> This is *especially* the case with *ssl library support, which a commen=
t
> of yours in a separate but related issue testifies to: "The patch fixes=
> build with libressl, libressl-devel, openssl111 but breaks openssl." [1=
]
>=20
> 3) Python build/upstream code fixes, especially for library support
> really need to 'go upstream' by default. It may be the case that this
> has already been solved up stream. I have seen libressl issues reported=
> upstream, but I have not followed their status or resolution. There's n=
o
> indication in the issue so far of that kind of analysis.
>=20
> It's much easier/faster to review and approve a commit by someone not o=
n
> the python team if there's been a upstream bug report and commit merged=
> to address the issue. We've worked very hard to reduce our diffs to
> upstream and, we still have a way to go.
>=20
> 4) This specific issue (building with libressl): the report and patch i=
s
> for 2.7, but there's no information provided for whether or not 3.x
> requires the same treatment, or if there are similar (exactly the same?=
,
> slightly different?) issues in those branches, and across libressl
> versions.
>=20
> Given we have multiple branches of Python to support at any one time,
> its especially important to address issues as consistently and
> completely across all of those versions, where relevant, as possible,
> with complete and extensive QA. Committing changes is easy,
> understanding, analysing, ensuring a complete and correct change
> proposal is the difficult part.
>=20
> Happy to discuss this with you further on IRC, #freebsd-python @ freeno=
de
>=20
> ./koobs
>=20
>=20
> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229223#c9
>=20
For something with as many dependencies as python-2.7 you should also be
contacting portmgr (well: Antoine) about whether an exp-run will be
necessary.
Cheers,
Matthew
--2HLEnm801Pn6rylKUrjLD5OVlPPiGVWZf--
--nBbf1nlaXYqItrzhnrAqS8iWhNZOAbdRC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEGfFU7L8RLlBUTj8wAFE/EOCp5OcFAlyHZ7NfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE5
RjE1NEVDQkYxMTJFNTA1NDRFM0YzMDAwNTEzRjEwRTBBOUU0RTcACgkQAFE/EOCp
5Oci+xAAq0tjEvV/hc6xk3loYEheAYvB3rohRAyBoqiTdLae4m/Y57EAOBqH23iu
lsgAV/LaNT9Hvg2cxWTcZhBfZpHuWSUEPjZ7qG/aVNuNbWzabUyL6lXl6Lp5nTu3
C+axhCfSndKGPunvVJYu9B2mmcOrRRIqWsBpNcJzhXx8npvFTpVOkQc0K/f0Q8gy
rZ+YwuyopxUelw+mwD4a46vnHGzFevTAf+nd6kzoRLE0oq+pL6wwTzZzcc5EMK5x
zdu13nnCEb1Qm5pEfLxtJc1VHvZBlXFJjpnEsiuO5X9rxnhbEW76NkajS1WhzHZW
hN7LlureXihc9EiHjj9a2t0LbNTqGCbl4WhoUZUYSeD1anhPxAlR315gklnOlCGQ
yQV81Q+prSAgCREaBifld1ruYQ0gWXFtxNtOJ4s22knGX2D2WVVzdbCPnZKAdGLq
Nd3EBvHVWxQGimGL0SEXIyhgt/f3GiNm0+IMCuVShXsCH3CUlyhoEa6pUR3dJoQF
yc7fMt+Att97YpYuvq2MIgYO2JLqQOrVn8yTGrs4CPJsZUR1LUpKO9qF15AXAUmY
CaQm72gMILeEi2iHBZp2ied4lBO+VyEMwgdwiOQzZ6BcnTZOeI607bxQ/i8PdDLK
9ywKNAV4Qb7LzEwc0MS9iPuCRcdFSVCsMWftLY+hajdG/Y/iKjU=
=+9Xs
-----END PGP SIGNATURE-----
--nBbf1nlaXYqItrzhnrAqS8iWhNZOAbdRC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f0bc14ad-34b5-ff25-0790-435c3114de96>