From owner-cvs-all Tue Dec 12 15:58:47 2000 From owner-cvs-all@FreeBSD.ORG Tue Dec 12 15:58:43 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from pike.osd.bsdi.com (pike.osd.bsdi.com [204.216.28.222]) by hub.freebsd.org (Postfix) with ESMTP id 477F737B400; Tue, 12 Dec 2000 15:58:43 -0800 (PST) Received: from foo.osd.bsdi.com (root@foo.osd.bsdi.com [204.216.28.137]) by pike.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id eBCNwcE03101; Tue, 12 Dec 2000 15:58:38 -0800 (PST) (envelope-from jhb@foo.osd.bsdi.com) Received: (from jhb@localhost) by foo.osd.bsdi.com (8.11.1/8.11.0) id eBCNvqw21257; Tue, 12 Dec 2000 15:57:52 -0800 (PST) (envelope-from jhb) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20001213102133.N77609@wantadilla.lemis.com> Date: Tue, 12 Dec 2000 15:57:52 -0800 (PST) Organization: BSD, Inc. From: John Baldwin To: Greg Lehey Subject: Re: cvs commit: src/sys/sys mutex.h Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: jhb@foo.osd.bsdi.com Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 12-Dec-00 Greg Lehey wrote: > On Monday, 11 December 2000 at 19:48:40 -0800, John Baldwin wrote: >> jhb 2000/12/11 19:48:40 PST >> >> Modified files: >> sys/sys mutex.h >> Log: >> Since _mtx_enter() and friends are static inline functions now instead of >> macros, the mutex KTR log entries don't actually have the useful filename >> and line numbers in the KTR_EXTEND case, so remove a comment claiming this >> and go back to one set of KTR strings. > > So we no longer know where the mutex was called from? That sounds > bad. Can't we use a wrapper macro for the inline function? We use a wrapper. We pass in teh file and line. This fixes the KTR messages so that you _do_ know where the mutexes come from again. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message