Date: Tue, 12 Dec 2000 15:57:52 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Greg Lehey <grog@lemis.com> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mutex.h Message-ID: <XFMail.001212155752.jhb@FreeBSD.org> In-Reply-To: <20001213102133.N77609@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-Dec-00 Greg Lehey wrote: > On Monday, 11 December 2000 at 19:48:40 -0800, John Baldwin wrote: >> jhb 2000/12/11 19:48:40 PST >> >> Modified files: >> sys/sys mutex.h >> Log: >> Since _mtx_enter() and friends are static inline functions now instead of >> macros, the mutex KTR log entries don't actually have the useful filename >> and line numbers in the KTR_EXTEND case, so remove a comment claiming this >> and go back to one set of KTR strings. > > So we no longer know where the mutex was called from? That sounds > bad. Can't we use a wrapper macro for the inline function? We use a wrapper. We pass in teh file and line. This fixes the KTR messages so that you _do_ know where the mutexes come from again. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001212155752.jhb>