Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Jan 2018 21:35:32 +0000 (UTC)
From:      Jeff Roberson <jeff@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r327746 - user/jeff/numa/sys/vm
Message-ID:  <201801092135.w09LZW6J016129@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jeff
Date: Tue Jan  9 21:35:31 2018
New Revision: 327746
URL: https://svnweb.freebsd.org/changeset/base/327746

Log:
  Review feedback.  New asserts, typos.

Modified:
  user/jeff/numa/sys/vm/vm_domainset.c

Modified: user/jeff/numa/sys/vm/vm_domainset.c
==============================================================================
--- user/jeff/numa/sys/vm/vm_domainset.c	Tue Jan  9 21:34:48 2018	(r327745)
+++ user/jeff/numa/sys/vm/vm_domainset.c	Tue Jan  9 21:35:31 2018	(r327746)
@@ -65,7 +65,7 @@ vm_domainset_iter_domain(struct vm_domainset_iter *di,
 
 	/*
 	 * object policy takes precedence over thread policy.  The policies
-	 * are immutable and unsychronized.  Updates can race but pointer
+	 * are immutable and unsynchronized.  Updates can race but pointer
 	 * loads are assumed to be atomic.
 	 */
 	if (obj != NULL && (domain = obj->domain.dr_policy) != NULL) {
@@ -106,6 +106,8 @@ static void
 vm_domainset_iter_next(struct vm_domainset_iter *di, int *domain)
 {
 
+	KASSERT(di->di_n > 0,
+	    ("vm_domainset_iter_first: Invalid n %d", di->di_n));
 	switch (di->di_domain->ds_policy) {
 	case DOMAINSET_POLICY_FIRSTTOUCH:
 		/*
@@ -155,6 +157,8 @@ vm_domainset_iter_first(struct vm_domainset_iter *di, 
 		panic("vm_domainset_iter_first: Unknown policy %d",
 		    di->di_domain->ds_policy);
 	}
+	KASSERT(di->di_n > 0,
+	    ("vm_domainset_iter_first: Invalid n %d", di->di_n));
 	KASSERT(*domain < vm_ndomains,
 	    ("vm_domainset_iter_first: Invalid domain %d", *domain));
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801092135.w09LZW6J016129>