From owner-freebsd-net@freebsd.org  Sun Mar  6 20:40:44 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BF7AAC1FB5;
 Sun,  6 Mar 2016 20:40:44 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1481E8E2;
 Sun,  6 Mar 2016 20:40:44 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u26KeWoZ084554;
 Sun, 6 Mar 2016 12:40:37 -0800 (PST)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201603062040.u26KeWoZ084554@gw.catspoiler.org>
Date: Sun, 6 Mar 2016 12:40:31 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: Dummynet AQM v0.1- CoDel and FQ-CoDel for FreeBSD's ipfw/dummynet 
To: ralsaadi@swin.edu.au
cc: aqm@ietf.org, freebsd-net@freebsd.org, freebsd-ipfw@freebsd.org,
 garmitage@swin.edu.au
In-Reply-To: <6545444AE21C2749939E637E56594CEA3C187192@gsp-ex02.ds.swin.edu.au>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Mar 2016 20:40:44 -0000

On 26 Feb, Rasool Al-Saadi wrote:
> Dear all,
> 
> I would like to announce that we (myself and Grenville Armitage)
> released Dummynet AQM v0.1, which is an independent implementation of
> CoDel and FQ-CoDel for FreeBSD's ipfw/dummynet framework, based on the
> IETF  CoDel [1] and FQ-CoDel [2] Internet-Drafts. We prepared patches
> for FreeBSD11-CURRENT-r295345  and FreeBSD 10.x-RELEASE (10.0, 10.1,
> 10.2), and a technical report  of our implementation.
> 
> Patches and documentation can be found in:
> http://caia.swin.edu.au/freebsd/aqm

The FreeBSD 10 patch applies cleanly to FreeBSD 10.3-PRERELEASE, but the
build fails on i386:

/usr/src/sbin/ipfw/dummynet.c:166:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[0],
                                ^~~~~~~~~~
/usr/src/sbin/ipfw/dummynet.c:167:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[1] );
                                ^~~~~~~~~~
/usr/src/sbin/ipfw/dummynet.c:177:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[0],
                                ^~~~~~~~~~
/usr/src/sbin/ipfw/dummynet.c:178:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[1],
                                ^~~~~~~~~~
/usr/src/sbin/ipfw/dummynet.c:179:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[3],
                                ^~~~~~~~~~
/usr/src/sbin/ipfw/dummynet.c:180:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[4],
                                ^~~~~~~~~~
/usr/src/sbin/ipfw/dummynet.c:181:5: error: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Werror,-Wformat]
                                ep->par[5]
                                ^~~~~~~~~~


The proper fix for this on FreeBSD is to cast these values to intmax_t
and use the %jd printf format.