From owner-freebsd-bugs  Sat Jan 13 10:20:20 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id B238A37B6A4
	for <freebsd-bugs@hub.freebsd.org>; Sat, 13 Jan 2001 10:20:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f0DIK1H39999;
	Sat, 13 Jan 2001 10:20:01 -0800 (PST)
	(envelope-from gnats)
Received: from starbug.ugh.net.au (starbug.ugh.net.au [203.31.238.37])
	by hub.freebsd.org (Postfix) with ESMTP
	id E0E3E37B69F; Sat, 13 Jan 2001 10:11:16 -0800 (PST)
Received: by starbug.ugh.net.au (Postfix, from userid 1000)
	id 81F2FA857; Sun, 14 Jan 2001 05:11:09 +1100 (EST)
Message-Id: <20010113181109.81F2FA857@starbug.ugh.net.au>
Date: Sun, 14 Jan 2001 05:11:09 +1100 (EST)
From: andrew@ugh.net.au
Reply-To: andrew@ugh.net.au
To: FreeBSD-gnats-submit@freebsd.org, obrien@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/24310: pkg_add has a misplaced )
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         24310
>Category:       bin
>Synopsis:       pkg_add has a misplaced )
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 13 10:20:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Andrew
>Release:        FreeBSD 4.2-STABLE i386
>Organization:
UgH!
>Environment:

pkg_install/add/perform.c revision 1.58

>Description:

A misplaced bracket causes the following error to be emitted from pkg_add -v:

Running mtree for poppwd-1.0..
mtree -U -f +MTREE_DIRS -d -e -p /usr/local >/dev/null
pkg_add: mtree returned a non-zero status - continuing

>How-To-Repeat:

pkg_add <blah>

>Fix:


--- perform.c.orig	Sun Jan 14 04:03:13 2001
+++ perform.c	Sun Jan 14 04:03:57 2001
@@ -366,7 +366,7 @@
 	if (Verbose)
 	    printf("mtree -U -f %s -d -e -p %s >%s\n", MTREE_FNAME, p ? p->name : "/", _PATH_DEVNULL);
 	if (!Fake) {
-	    if (vsystem("/usr/sbin/mtree -U -f %s -d -e -p %s >%s", MTREE_FNAME, p ? p->name : "/"), _PATH_DEVNULL)
+	    if (vsystem("/usr/sbin/mtree -U -f %s -d -e -p %s >%s", MTREE_FNAME, p ? p->name : "/", _PATH_DEVNULL))
 		warnx("mtree returned a non-zero status - continuing");
 	}
 	unlink(MTREE_FNAME);

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message