From owner-p4-projects@FreeBSD.ORG  Tue Oct  3 05:19:37 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 46D9916A412; Tue,  3 Oct 2006 05:19:37 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 22BBE16A403
	for <perforce@freebsd.org>; Tue,  3 Oct 2006 05:19:37 +0000 (UTC)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C5F7E43D49
	for <perforce@freebsd.org>; Tue,  3 Oct 2006 05:19:36 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k935Jaaf000863
	for <perforce@freebsd.org>; Tue, 3 Oct 2006 05:19:36 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k935JaTf000860
	for perforce@freebsd.org; Tue, 3 Oct 2006 05:19:36 GMT
	(envelope-from imp@freebsd.org)
Date: Tue, 3 Oct 2006 05:19:36 GMT
Message-Id: <200610030519.k935JaTf000860@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 107141 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Oct 2006 05:19:37 -0000

http://perforce.freebsd.org/chv.cgi?CH=107141

Change 107141 by imp@imp_lighthouse on 2006/10/03 05:19:19

	Better panic messages

Affected files ...

.. //depot/projects/arm/src/sys/dev/mmc/mmc.c#17 edit

Differences ...

==== //depot/projects/arm/src/sys/dev/mmc/mmc.c#17 (text+ko) ====

@@ -128,7 +128,7 @@
 	sc = device_get_softc(busdev);
 	MMC_LOCK(sc);
 	if (sc->owner)
-		panic("How did I get here?");
+		panic("mmc: host bridge didn't seralize us.");
 	sc->owner = dev;
 	MMC_UNLOCK(sc);
 	return (0);
@@ -143,9 +143,9 @@
 	sc = device_get_softc(busdev);
 	MMC_LOCK(sc);
 	if (!sc->owner)
-		panic("No owner?");
+		panic("mmc: releasing unowned bus.");
 	if (sc->owner != dev)
-		panic("Wrong owner releasing?");
+		panic("mmc: you don't own the bus.  game over.");
 	MMC_UNLOCK(sc);
 	err = MMCBR_RELEASE_HOST(device_get_parent(busdev), dev);
 	if (err)