From owner-cvs-src@FreeBSD.ORG Thu May 19 15:47:37 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC67816A4CE; Thu, 19 May 2005 15:47:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9402543D7B; Thu, 19 May 2005 15:47:37 +0000 (GMT) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j4JFlb4U045237; Thu, 19 May 2005 15:47:37 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j4JFlb6t045236; Thu, 19 May 2005 15:47:37 GMT (envelope-from marius) Message-Id: <200505191547.j4JFlb6t045236@repoman.freebsd.org> From: Marius Strobl Date: Thu, 19 May 2005 15:47:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sparc64/isa isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2005 15:47:38 -0000 marius 2005-05-19 15:47:37 UTC FreeBSD src repository Modified files: sys/sparc64/isa isa.c Log: - When iterating over the register resources of the children don't use the iteration variable as the RID when adding the respective resource to the child via bus_set_resource(). In case a device has both I/O and memory resources this generates gaps in the newbus resources of the child, e.g. its first memory resource might end up as RID 1. To solve this mimic resource_list_add_next() via resource_list_find() and bus_set_resource(); we can't just use resource_list_add_next() here as this would circumvent the limit checks in isa_set_resource() of the common ISA code. This however is more or less a theoretical problem so far as all known ISA devices on sparc64 soley use I/O space. - Just use bus_generic_rl_release_resource() for isa_release_resource() instead of re-implementing the former. - Improve some comments to better reflect reality, minor clean-up and simplifications, return NULL instead of 0 were appropriate. Revision Changes Path 1.16 +33 -27 src/sys/sparc64/isa/isa.c