Date: Sat, 25 Apr 2015 14:28:20 +0800 From: Ting-Wei Lan <lantw44@gmail.com> To: Jakob Fink <jfink@gmx.at> Cc: gnome@FreeBSD.org Subject: Re: Patch for pulseaudio-6.0 / Volume Change through pactl Message-ID: <1429943300.48064.4.camel@gmail.com> In-Reply-To: <trinity-0707c69e-5955-4003-a20e-59a2299b2ead-1429881877906@3capp-gmx-bs61> References: <trinity-0707c69e-5955-4003-a20e-59a2299b2ead-1429881877906@3capp-gmx-bs61>
next in thread | previous in thread | raw e-mail | index | archive | help
於 五，2015-04-24 於 15:24 +0200，Jakob Fink 提到： > Dear Maintainers, > > > I recently started to use pulseaudio. I am using the pactl tool to > change volume in some scripts. > > There is a bug only concerning freebsd in the pulseaudio source: in > pulsecore/core_util.c only locale.h in included. xlocale.h is missing. > > This leads to an undefined return value in strtod_l, which is used to > convert the volume string taken from the commandline into a double, > using the currently set locale. > This double is then used unchecked to set the volume, which leads > pulseaudio to amplify the output by a few thousand percent and nearly > blow my speakers (and my eardrums) in the process. > > I retraced the bug to this function and made the attached patch. On my > system, it fixes the issue. It would be great if you could include it > in the ports tree to prevent countless deaf freebsd users in the > future. ;) It is nice to see the patch. Are you going to send the patch to the upstream so users who compile pulseaudio from the upstream git repository can also get the fix? > > > Regards, > Jakob > _______________________________________________ > freebsd-gnome@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-gnome > To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1429943300.48064.4.camel>