From owner-freebsd-gnome@FreeBSD.ORG  Sun Jan 22 17:17:43 2012
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B468B106564A
	for <gnome@freebsd.org>; Sun, 22 Jan 2012 17:17:43 +0000 (UTC)
	(envelope-from kdefreebsd@heesakkers.info)
Received: from server4.ohos.nl (server4.ohos.nl
	[IPv6:2a00:d880:0:6::c951:214d])
	by mx1.freebsd.org (Postfix) with ESMTP id 56D528FC0C
	for <gnome@freebsd.org>; Sun, 22 Jan 2012 17:17:43 +0000 (UTC)
Received: from [2001:470:1f15:1555::2] (helo=pcoliver.heesakkers.info)
	by server4.ohos.nl with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.77)
	(envelope-from <kdefreebsd@heesakkers.info>)
	id 1Rp12R-0003re-Ow; Sun, 22 Jan 2012 18:17:20 +0100
From: Oliver Heesakkers <kdefreebsd@heesakkers.info>
To: kde-freebsd@kde.org, gnome@freebsd.org
Date: Sun, 22 Jan 2012 18:17:02 +0100
Message-ID: <2168086.DZZMc1pLeQ@pcoliver.heesakkers.info>
User-Agent: KMail/4.7.3 (FreeBSD/9.0-RELEASE; KDE/4.7.3; amd64; ; )
In-Reply-To: <201201221434.19798.makc@issp.ac.ru>
References: <5842707.er64rEAdVg@pcoliver.heesakkers.info>
	<201201221434.19798.makc@issp.ac.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: 
Subject: Re: [kde-freebsd] INSTALLS_ICONS and qt4 software
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jan 2012 17:17:43 -0000

Op zo 22 jan 2012 14:34:18 schreef Max Brazhnikov:
(...) 
> Yes, your are right, KDE4 ports don't need INSTALLS_ICONS.
> 
> > When a Gnome-user installs this port, would he/she require
> > INSTALLS_ICONS
> > to have the icon show up?
> 
> Probably yes.
> 
> > If so, is there a standard way for the ports Makefile to check for the
> > existence or use of Gnome so I can optionally set INSTALLS_ICONS? I
> > think
> > it's overkill to make an actual OPTIONS= line for it.
> 
> You can add WITH_GNOME knob, or do nothing.
> 
> Actually I don't understand why ports should care about Gnome's icons cache.
> If Gnome desktop need up-to-date icons cache to work, it should take
> responsibility on updating the cache (like other desktops do :)
> 
> Alternatively, INSTALLS_ICONS may be changed to do its work only if Gnome is
> installed. But that's up to gnome@ team to decide.
> 


Thanks for getting back to me. I submitted a patch[1] last friday which does 
this:

.if exists(${LOCALBASE}/bin/gnome-session)
INSTALLS_ICONS=        yes
.endif

It was committed without questions or remarks

[1]. http://www.freebsd.org/cgi/query-pr.cgi?pr=164344