Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Jan 2023 11:50:05 -0700
From:      Adam Weinberger <adamw@adamw.org>
To:        =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option
Message-ID:  <CAP7rwcgBQD3oQJRKyvjposA=WW1%2BJku7Xzv_mF2-rcwJy-eqdg@mail.gmail.com>
In-Reply-To: <202301161248.30GCmHnK091914@gitrepo.freebsd.org>
References:  <202301161248.30GCmHnK091914@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000027987d05f2660e4e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa <fernape@freebsd.o=
rg>
wrote:

> The branch main has been updated by fernape:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e32255=
5f0afbb8383
>
> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383
> Author:     Fernando Apestegu=C3=ADa <fernape@FreeBSD.org>
> AuthorDate: 2023-01-15 19:29:38 +0000
> Commit:     Fernando Apestegu=C3=ADa <fernape@FreeBSD.org>
> CommitDate: 2023-01-16 12:44:02 +0000
>
>     dns/unbound: add dynlib port option
>

>     PR:             268942
>     Reported by:    me@rcm.sh
>     Approved by:    jaap@NLnetLabs.nl (maintainer)
> ---
>  dns/unbound/Makefile | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
>
Does this need a pkg-plist change? If the plist is the same with this
option on and off, what is this option actually controlling?

# Adam

diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile
> index 6d101575fd4f..3e0ad7dcdcc3 100644
> --- a/dns/unbound/Makefile
> +++ b/dns/unbound/Makefile
> @@ -1,5 +1,6 @@
>  PORTNAME=3D      unbound
>  DISTVERSION=3D   1.17.1
> +PORTREVISION=3D  1
>  CATEGORIES=3D    dns
>  MASTER_SITES=3D  https://www.nlnetlabs.nl/downloads/unbound/
>
> @@ -32,15 +33,16 @@ PORTDOCS=3D   CNAME-basedRedirectionDesignNotes.pdf
> CREDITS Changelog \
>                 ietf67-design-02.pdf requirements.txt
>
>  OPTIONS_DEFINE=3D                DEP-RSA1024 DNSCRYPT DNSTAP DOCS DOH EC=
DSA
> EVAPI \
> -                       FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN
> PYTHON \
> -                       SUBNET TFOCL TFOSE THREADS
> -OPTIONS_DEFAULT=3D       DNSCRYPT DOH ECDSA GOST LIBEVENT THREADS
> +                       DYNLIB FILTER_AAAA GOST HIREDIS LIBEVENT
> MUNIN_PLUGIN \
> +                       PYTHON SUBNET TFOCL TFOSE THREADS
> +OPTIONS_DEFAULT=3D       DNSCRYPT DOH DYNLIB ECDSA GOST LIBEVENT THREADS
>  OPTIONS_SUB=3D           yes
>
>  DEP-RSA1024_DESC=3D      Deprecate the use of RSA 1024 keys
>  DNSCRYPT_DESC=3D         Enable dnscrypt support
>  DNSTAP_DESC=3D           Enable dnstap logging support
>  DOH_DESC=3D              Enable DNS-over-HTTPS support
> +DYNLIB_DESC=3D           Enable dynamic (shared) library support
>  ECDSA_DESC=3D            Enable ECDSA (elliptic curve) support (OpenSSL =
>=3D
> 1.0)
>  EVAPI_DESC=3D            (Experimental) pluggable event based libunbound
> API support
>  FILTER_AAAA_DESC=3D      Build with AAAA filter functionality (contrib)
> @@ -63,6 +65,7 @@ DNSTAP_LIB_DEPENDS=3D           libfstrm.so:devel/fstrm=
 \
>  DNSTAP_CONFIGURE_ENABLE=3D       dnstap
>  DOH_LIB_DEPENDS=3D               libnghttp2.so:www/libnghttp2
>  DOH_CONFIGURE_ON=3D              --with-libnghttp2
> +DYNLIB_CONFIGURE_ON=3D           --with-dynlibmodule
>  ECDSA_CONFIGURE_ENABLE=3D                ecdsa
>  ECDSA_VARS=3D                    DEPENDS_ARGS+=3DWITH_ECDSA=3Dyes
>  EVAPI_CONFIGURE_ENABLE=3D                event-api
>


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org

--00000000000027987d05f2660e4e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,sans-serif"><br></div></div><br><div class=3D"gmail_quote"><=
div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 16, 2023 at 5:48 AM Fernan=
do Apestegu=C3=ADa &lt;<a href=3D"mailto:fernape@freebsd.org">fernape@freeb=
sd.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">The branch main has been updated by fernape:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa6711=
0ba6d2d1e322555f0afbb8383" rel=3D"noreferrer" target=3D"_blank">https://cgi=
t.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322555f0afbb8383</=
a><br>
<br>
commit 38e6e935efa67110ba6d2d1e322555f0afbb8383<br>
Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa &lt;fernape@FreeBSD.org=
&gt;<br>
AuthorDate: 2023-01-15 19:29:38 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa &lt;fernape@FreeBSD.org=
&gt;<br>
CommitDate: 2023-01-16 12:44:02 +0000<br>
<br>
=C2=A0 =C2=A0 dns/unbound: add dynlib port option <br></blockquote><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex">
<br>
=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0268942<br>
=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 <a href=3D"mailto:me@rcm.sh" target=
=3D"_blank">me@rcm.sh</a><br>
=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 jaap@NLnetLabs.nl (maintainer)<br>
---<br>
=C2=A0dns/unbound/Makefile | 9 ++++++---<br>
=C2=A01 file changed, 6 insertions(+), 3 deletions(-)<br>
<br></blockquote><div><br></div><div style=3D"font-family:arial,sans-serif"=
 class=3D"gmail_default">Does this need a pkg-plist change? If the plist is=
 the same with this option on and off, what is this option actually control=
ling?</div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_defau=
lt"><br></div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_de=
fault"># Adam</div><div style=3D"font-family:arial,sans-serif" class=3D"gma=
il_default"><br></div><div style=3D"font-family:arial,sans-serif" class=3D"=
gmail_default"></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
diff --git a/dns/unbound/Makefile b/dns/unbound/Makefile<br>
index 6d101575fd4f..3e0ad7dcdcc3 100644<br>
--- a/dns/unbound/Makefile<br>
+++ b/dns/unbound/Makefile<br>
@@ -1,5 +1,6 @@<br>
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 unbound<br>
=C2=A0DISTVERSION=3D=C2=A0 =C2=A01.17.1<br>
+PORTREVISION=3D=C2=A0 1<br>
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 dns<br>
=C2=A0MASTER_SITES=3D=C2=A0 <a href=3D"https://www.nlnetlabs.nl/downloads/u=
nbound/" rel=3D"noreferrer" target=3D"_blank">https://www.nlnetlabs.nl/down=
loads/unbound/</a><br>
<br>
@@ -32,15 +33,16 @@ PORTDOCS=3D=C2=A0 =C2=A0CNAME-basedRedirectionDesignNot=
es.pdf CREDITS Changelog \<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ietf67-design-02.pd=
f requirements.txt<br>
<br>
=C2=A0OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 DEP-RSA1024 DNSCRYPT DNSTAP DOCS DOH ECDSA EVAPI \<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN PYTHON \<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0SUBNET TFOCL TFOSE THREADS<br>
-OPTIONS_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0DNSCRYPT DOH ECDSA GOST LIBEV=
ENT THREADS<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0DYNLIB FILTER_AAAA GOST HIREDIS LIBEVENT MUNIN_PLUGIN \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0PYTHON SUBNET TFOCL TFOSE THREADS<br>
+OPTIONS_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0DNSCRYPT DOH DYNLIB ECDSA GOS=
T LIBEVENT THREADS<br>
=C2=A0OPTIONS_SUB=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0yes<br>
<br>
=C2=A0DEP-RSA1024_DESC=3D=C2=A0 =C2=A0 =C2=A0 Deprecate the use of RSA 1024=
 keys<br>
=C2=A0DNSCRYPT_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dnscrypt sup=
port<br>
=C2=A0DNSTAP_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dnstap =
logging support<br>
=C2=A0DOH_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Enable DN=
S-over-HTTPS support<br>
+DYNLIB_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Enable dynamic (sha=
red) library support<br>
=C2=A0ECDSA_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Enable ECDSA (=
elliptic curve) support (OpenSSL &gt;=3D 1.0)<br>
=C2=A0EVAPI_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (Experimental)=
 pluggable event based libunbound API support<br>
=C2=A0FILTER_AAAA_DESC=3D=C2=A0 =C2=A0 =C2=A0 Build with AAAA filter functi=
onality (contrib)<br>
@@ -63,6 +65,7 @@ DNSTAP_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0libfstrm.so:devel/fstrm \<br>
=C2=A0DNSTAP_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0dnstap<br>
=C2=A0DOH_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0libnghttp2.so:www/libnghttp2<br>
=C2=A0DOH_CONFIGURE_ON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -=
-with-libnghttp2<br>
+DYNLIB_CONFIGURE_ON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-dynl=
ibmodule<br>
=C2=A0ECDSA_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 ecdsa<br>
=C2=A0ECDSA_VARS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 DEPENDS_ARGS+=3DWITH_ECDSA=3Dyes<br>
=C2=A0EVAPI_CONFIGURE_ENABLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 event-api<br>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div>Adam Weinberger=
</div><div><a href=3D"mailto:adamw@adamw.org" target=3D"_blank">adamw@adamw=
.org</a></div><div><a href=3D"https://www.adamw.org" target=3D"_blank">http=
s://www.adamw.org</a></div></div></div></div></div></div>

--00000000000027987d05f2660e4e--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcgBQD3oQJRKyvjposA=WW1%2BJku7Xzv_mF2-rcwJy-eqdg>