From owner-svn-src-head@freebsd.org  Tue Feb 20 11:42:53 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F10FF20F19;
 Tue, 20 Feb 2018 11:42:53 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BA6DA7255B;
 Tue, 20 Feb 2018 11:42:52 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w1KBgf9c070176
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 20 Feb 2018 13:42:44 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w1KBgf9c070176
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id w1KBgfXx070175;
 Tue, 20 Feb 2018 13:42:41 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 20 Feb 2018 13:42:41 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r329639 - head/sys/kern
Message-ID: <20180220114241.GH94212@kib.kiev.ua>
References: <201802201052.w1KAq7jQ057924@repo.freebsd.org>
 <2A592C68-C6B3-4BAA-975C-02D325292C02@lists.zabbadoz.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2A592C68-C6B3-4BAA-975C-02D325292C02@lists.zabbadoz.net>
User-Agent: Mutt/1.9.3 (2018-01-21)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 11:42:53 -0000

On Tue, Feb 20, 2018 at 10:58:33AM +0000, Bjoern A. Zeeb wrote:
> On 20 Feb 2018, at 10:52, Mateusz Guzik wrote:
> 
> > Author: mjg
> > Date: Tue Feb 20 10:52:07 2018
> > New Revision: 329639
> > URL: https://svnweb.freebsd.org/changeset/base/329639
> >
> > Log:
> >   Make killpg1 perform process validity checks without proc lock held.
> 
> I appreciate all these locking improvements!
> 
> I would feel a lot more easy about them if the commit message would also 
> detail why these changes are possible (e.g. only read-only variables 
> accessed, or variables only ever accessed thread local, ..) and not just 
> what the change is (which the diff also tells).
Removing PRS_NEW is certainly not safe.

> 
> Also, are there people reviewing all these changes?
>