From owner-dev-commits-src-main@freebsd.org  Thu Aug  5 18:49:27 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 77D696688B3;
 Thu,  5 Aug 2021 18:49:27 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Ggd1z2VcBz3nGK;
 Thu,  5 Aug 2021 18:49:27 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2020.home.selasky.org (unknown [178.17.145.105])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 6DC8A2602DE;
 Thu,  5 Aug 2021 20:49:20 +0200 (CEST)
Subject: Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS
To: Andrew Gallatin <gallatin@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202108051710.175HAP1D031061@gitrepo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <b4ae5fcf-31d3-6864-8df0-a468fd58f637@selasky.org>
Date: Thu, 5 Aug 2021 20:49:10 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <202108051710.175HAP1D031061@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4Ggd1z2VcBz3nGK
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Aug 2021 18:49:27 -0000

On 8/5/21 7:10 PM, Andrew Gallatin wrote:
> +		tsleep_sbt(sc, PZERO, "waiting for work", SBT_MAX, SBT_1S, 0);

Hi,

This basically puts a useless callout into the timer subsystem forever. 
I think if you don't care about this tsleep being accurate, then lock 
Giant and use sbt = 0.

In between, I think that assert in question should be updated.

--HPS