Skip site navigation (1)Skip section navigation (2)
Date:      Tue,  3 Jun 2008 10:50:43 +0800 (CST)
From:      Yi-Huan Chan <yhchan@csie.nctu.edu.tw>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        mail@maxlor.com
Subject:   ports/124226: [PATCH] ports-mgmt/psearch: fix psearch does not work
Message-ID:  <20080603025043.6852158D8@hubert.ckefgisc.org>
Resent-Message-ID: <200806030310.m533A1UA088208@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         124226
>Category:       ports
>Synopsis:       [PATCH] ports-mgmt/psearch: fix psearch does not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 03 03:10:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Yi-Huan Chan
>Release:        FreeBSD 7.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD hubert.ckefgisc.org 7.0-STABLE FreeBSD 7.0-STABLE #0: Fri May 23 01:16:29 UTC 2008
>Description:

The function Index::parse_line() should return 'true', or psearch may not work.

Added file(s):
- files/patch-index.cpp

Port maintainer (mail@maxlor.com) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- psearch-2.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/ports-mgmt/psearch.orig/Makefile /usr/ports/ports-mgmt/psearch/Makefile
--- /usr/ports/ports-mgmt/psearch.orig/Makefile	2008-06-03 10:32:56.000000000 +0800
+++ /usr/ports/ports-mgmt/psearch/Makefile	2008-06-03 10:42:59.000000000 +0800
@@ -7,6 +7,7 @@
 
 PORTNAME=	psearch
 PORTVERSION=	2.0
+PORTREVISION=	1
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	http://www.maxlor.com/files/
 
diff -ruN --exclude=CVS /usr/ports/ports-mgmt/psearch.orig/files/patch-index.cpp /usr/ports/ports-mgmt/psearch/files/patch-index.cpp
--- /usr/ports/ports-mgmt/psearch.orig/files/patch-index.cpp	1970-01-01 08:00:00.000000000 +0800
+++ /usr/ports/ports-mgmt/psearch/files/patch-index.cpp	2008-06-03 10:37:13.000000000 +0800
@@ -0,0 +1,20 @@
+--- index.cpp.orig	2008-06-03 10:34:15.000000000 +0800
++++ index.cpp	2008-06-03 10:34:45.000000000 +0800
+@@ -33,7 +33,7 @@
+ 	string::size_type oldposition = 0;
+ 	string::size_type position;
+ 		
+-	for (int i = 0; i < fields_num; ++i) {
++	for (unsigned int i = 0; i < fields_num; ++i) {
+ 		position = line.find('|', oldposition);
+ 		if (position == string::npos) { return false; }
+ 		fields[i] = line.substr(oldposition, position - oldposition);
+@@ -42,6 +42,8 @@
+ 	
+ 	fields[Path] = fields[Path].substr(11); // strip leading '/usr/ports/'
+ 	if (need_categories) { _categories.clear(); }
++
++        return true;
+ }
+ 
+ 
--- psearch-2.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080603025043.6852158D8>