From owner-cvs-src@FreeBSD.ORG  Fri Feb  8 23:01:40 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E693716A419;
	Fri,  8 Feb 2008 23:01:40 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id D21C613C474;
	Fri,  8 Feb 2008 23:01:40 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m18N1e83016481;
	Fri, 8 Feb 2008 23:01:40 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m18N1ecr016480;
	Fri, 8 Feb 2008 23:01:40 GMT (envelope-from rwatson)
Message-Id: <200802082301.m18N1ecr016480@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Fri, 8 Feb 2008 23:01:40 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/fs/coda coda_vnops.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2008 23:01:41 -0000

rwatson     2008-02-08 23:01:40 UTC

  FreeBSD src repository

  Modified files:
    sys/fs/coda          coda_vnops.c 
  Log:
  Before invoking vnode operations on cache vnodes, acquire the vnode
  locks of those vnodes.  Probably, Coda should do the same lock sharing/
  pass-through that is done for nullfs, but in the mean time this ensures
  that locks are adequately held to prevent corruption of data structures
  in the cache file system.
  
  Assuming most operations came from the top layer of Coda and weren't
  performed directly on the cache vnodes, in practice this corruption was
  relatively unlikely as the Coda vnode locks were ensuring exclusive
  access for most consumers.
  
  This causes WITNESS to squeal like a pig immediately when Coda is used,
  rather than waiting until file close; I noticed these problems because
  of the lack of said squealing.
  
  MFC after:      1 month
  
  Revision  Changes    Path
  1.86      +9 -1      src/sys/fs/coda/coda_vnops.c