From nobody Wed May 1 17:08:05 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VV3Rl1Rq1z5Jjg0 for ; Wed, 1 May 2024 17:08:19 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VV3Rk6dKVz4LqZ for ; Wed, 1 May 2024 17:08:18 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-41ba1ba55ebso38531445e9.1 for ; Wed, 01 May 2024 10:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714583297; x=1715188097; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=18JujI/LYhxV9+gUh2P0LNglAEuFomX+fGTda1weG2o=; b=PFYhebVpe0L5t9Rfl8Mj+iIPv+yCHRWQevAPw0h+Td2gkoF+3mzookYAxoWz81ysPp Eu9F5N5C9CujutcwsxCEKO8oP6fpeG5EpuFVQmYyM8mOL9Po/Y33MEXfABFGGdSgfOUP 0CIWdNW6dZ0nAc24vPJbXL7jOQnFpJo47voYCfQDby3ot3kqU/K6FoqEoioQe5dl9m/f BUUptktU/lwQ1oxWdZY4zqVACTg/PbkDTLHpZ1HcpK9C5Cufk89opMNPtYSG+FjoaSqV 6lN5vxsPUy1ScW0oCjIaTzFXC3ABgcYPIMZY1sZb61eKMHUREKC6lFf6yJ85PLuXtaLg YwQQ== X-Forwarded-Encrypted: i=1; AJvYcCU+nAnXIlyPcZCMLvTlHAYK8rD2AQn8nt+ZLS+3/qbmGMsKIepL6fUbRNKceN5SAceTWK4qiQam/RR+yXtJadgAZCdvVOrBtKilwrp3nxdNlg== X-Gm-Message-State: AOJu0YwH9sW22eOpbhRjGw8xWy5Cws8YqQrV6dyTjjZYli+yBYnKW3MP z2qih9qqWsFjN83qXVgIT0Ip3gDX0CJQSJNDvp6L0d6aDYGgiy6WUQhJC87XgCk= X-Google-Smtp-Source: AGHT+IE158Zt1A69fwXdRn2D8l4Zblb5B6lVqcGVLsEsNp+vAS7/A2TgAmwVP+fpWAH+h/ozomNa+w== X-Received: by 2002:a05:600c:3b0d:b0:41a:c592:64ff with SMTP id m13-20020a05600c3b0d00b0041ac59264ffmr2555938wms.35.1714583297072; Wed, 01 May 2024 10:08:17 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c220a00b0041bef325c4esm8495390wml.1.2024.05.01.10.08.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 May 2024 10:08:16 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: git: e60ca52b72e5 - main - Out of tree modules should be built with DTrace by default. From: Jessica Clarke In-Reply-To: <202405011701.441H17Wf008095@gitrepo.freebsd.org> Date: Wed, 1 May 2024 18:08:05 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <909C5B39-B3C0-4111-BE59-4F9B4576C4C8@freebsd.org> References: <202405011701.441H17Wf008095@gitrepo.freebsd.org> To: "George V. Neville-Neil" X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4VV3Rk6dKVz4LqZ On 1 May 2024, at 18:01, George V. Neville-Neil wrote: >=20 > The branch main has been updated by gnn: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3De60ca52b72e518f8394615bdad9cd9c8= 5764caa2 >=20 > commit e60ca52b72e518f8394615bdad9cd9c85764caa2 > Author: George V. Neville-Neil > AuthorDate: 2024-05-01 17:00:52 +0000 > Commit: George V. Neville-Neil > CommitDate: 2024-05-01 17:00:52 +0000 >=20 > Out of tree modules should be built with DTrace by default. > --- > share/examples/modules/Makefile | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/share/examples/modules/Makefile = b/share/examples/modules/Makefile > index 0f0a2fb01e8a..bc7f6f6a57ac 100644 > --- a/share/examples/modules/Makefile > +++ b/share/examples/modules/Makefile > @@ -4,3 +4,5 @@ KMOD=3D skel > SRCS=3D skel.c >=20 > .include > + > +CFLAGS:=3D ${CFLAGS:N -DKDTRACE_HOOKS} I believe this is a no-op in practice, and definitely doesn=E2=80=99t do = what you want? :N is "select all words that don=E2=80=99t match the given = pattern", so this expands to CFLAGS with any instances of " -DKDTRACE_HOOKS" removed. But that=E2=80=99s a no-op, because the space won=E2=80=99t be = present in the word itself unless you start quoting things, and it then wouldn=E2=80=99t = be a valid compiler flag. Jess