From owner-svn-src-head@freebsd.org Sun Apr 2 16:33:17 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08CDAD2A350; Sun, 2 Apr 2017 16:33:17 +0000 (UTC) (envelope-from dchagin@mordor.heemeyer.club) Received: from heemeyer.club (heemeyer.club [108.61.204.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "heemeyer.club", Issuer "heemeyer.club" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BAFED66E; Sun, 2 Apr 2017 16:33:16 +0000 (UTC) (envelope-from dchagin@mordor.heemeyer.club) Received: from mordor.heemeyer.club (dchagin.static.corbina.ru [78.107.232.239]) by heemeyer.club (8.15.2/8.15.1) with ESMTPS id v32GXAsa019932 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 2 Apr 2017 16:33:13 GMT (envelope-from dchagin@mordor.heemeyer.club) X-Authentication-Warning: heemeyer.club: Host dchagin.static.corbina.ru [78.107.232.239] claimed to be mordor.heemeyer.club Received: from mordor.heemeyer.club (localhost [127.0.0.1]) by mordor.heemeyer.club (8.15.2/8.15.1) with ESMTPS id v32GX6cY044899 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 2 Apr 2017 19:33:07 +0300 (MSK) (envelope-from dchagin@mordor.heemeyer.club) Received: (from dchagin@localhost) by mordor.heemeyer.club (8.15.2/8.15.2/Submit) id v32GX684044898; Sun, 2 Apr 2017 19:33:06 +0300 (MSK) (envelope-from dchagin) Date: Sun, 2 Apr 2017 19:33:06 +0300 From: Chagin Dmitry To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316393 - head/sys/compat/linux Message-ID: <20170402163306.GA44865@mordor.heemeyer.club> References: <201704020746.v327kDSN042840@repo.freebsd.org> <20170402133651.GJ43712@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170402133651.GJ43712@kib.kiev.ua> User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Apr 2017 16:33:17 -0000 On Sun, Apr 02, 2017 at 04:36:51PM +0300, Konstantin Belousov wrote: > On Sun, Apr 02, 2017 at 07:46:13AM +0000, Dmitry Chagin wrote: > > Author: dchagin > > Date: Sun Apr 2 07:46:13 2017 > > New Revision: 316393 > > URL: https://svnweb.freebsd.org/changeset/base/316393 > > > > Log: > > As noted by bde@ negative tv_sec values are not checked for overflow, > > so overflow can still occur. Fix that. Also remove the extra check for > > tv_sec size as under COMPAT_LINUX32 it is always true. > > > > Pointed out by: bde@ > > > > MFC after: 1 week > > > > Modified: > > head/sys/compat/linux/linux_time.c > > > > Modified: head/sys/compat/linux/linux_time.c > > ============================================================================== > > --- head/sys/compat/linux/linux_time.c Sun Apr 2 07:11:15 2017 (r316392) > > +++ head/sys/compat/linux/linux_time.c Sun Apr 2 07:46:13 2017 (r316393) > > @@ -125,8 +125,7 @@ native_to_linux_timespec(struct l_timesp > > > > LIN_SDT_PROBE2(time, native_to_linux_timespec, entry, ltp, ntp); > > #ifdef COMPAT_LINUX32 > > - if (ntp->tv_sec > INT_MAX && > > - sizeof(ltp->tv_sec) != sizeof(ntp->tv_sec)) > > + if (ntp->tv_sec > INT_MAX || ntp->tv_sec < INT_MIN) > This line reads as only tv_sec == INT_MAX case results in non-EOVERFLOW > condition. > should I rewrite it like: if (ntp->tv_sec < INT_MIN || ntp->tv_sec > INT_MAX) ? > > return (EOVERFLOW); > > #endif > > ltp->tv_sec = ntp->tv_sec; --