From owner-freebsd-current@freebsd.org  Sun Jul 15 18:26:04 2018
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D6841049EAA
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Sun, 15 Jul 2018 18:26:04 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "troutmask", Issuer "troutmask" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9808F91E7E;
 Sun, 15 Jul 2018 18:26:03 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
 by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FIQ0X6031766
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 15 Jul 2018 11:26:00 -0700 (PDT)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FIQ0l4031765;
 Sun, 15 Jul 2018 11:26:00 -0700 (PDT) (envelope-from sgk)
Date: Sun, 15 Jul 2018 11:26:00 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: "K. Macy" <kmacy@freebsd.org>
Cc: Ian Lepore <ian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: [PATCH] Recent libm additions
Message-ID: <20180715182600.GB31164@troutmask.apl.washington.edu>
Reply-To: sgk@troutmask.apl.washington.edu
References: <20180715150638.GA30154@troutmask.apl.washington.edu>
 <1531674041.26036.1.camel@freebsd.org>
 <20180715171737.GA31164@troutmask.apl.washington.edu>
 <CAHM0Q_OMYUe4CDemC8Gx9AGzA+wK0cctwUhHieeQi2xdDs0urA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHM0Q_OMYUe4CDemC8Gx9AGzA+wK0cctwUhHieeQi2xdDs0urA@mail.gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2018 18:26:04 -0000

On Sun, Jul 15, 2018 at 10:21:25AM -0700, K. Macy wrote:
> >
> > Well, actually, the functions in polevll.c should have been copied
> > into ld80/e_powl.c, and polevall.c should never have been committed.
> > Unfortunately, the code was not reviewed for correctness.
> 
> That is not correct. Please stop repeating it. Bruce Evans and John
> Baldwin were both looped in. Neither made this observation.

I read the differential review.  The code was not reviewed by John.
He reviewed how it was hooked into the build.  Bruce does not appear
in the differential review.   There is no record on freebsd-numerics
about the patch.

powl on i686-class hardware is likely broken as it does not use
the LD80C macro to construct literal constants.

-- 
Steve