From owner-freebsd-arch Sat Feb 2 15:28:45 2002 Delivered-To: freebsd-arch@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 0941437B404 for ; Sat, 2 Feb 2002 15:28:43 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id EB0EB5341; Sun, 3 Feb 2002 00:28:40 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: "M. Warner Losh" , , , Subject: Re: __P macro question References: <20020131231008.P4085-100000@gamplex.bde.org> From: Dag-Erling Smorgrav Date: 03 Feb 2002 00:28:40 +0100 In-Reply-To: <20020131231008.P4085-100000@gamplex.bde.org> Message-ID: Lines: 23 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > When removing __P(()), don't do it like login/login.c rev.1.80: > - mix the removal with nontrivial rewriting of the code to make it harder > for auditors to see the critical changes. Change all the function > headers too, but don't de-verbosify the code by removing the prototypes > made redundant by this. > - be sure to unsort the prototypes and add excessive indentation to them. > Using a low quality script to regenerate all the prototypes is a good > way to do this. > ;-) STFU, Bruce. I can understand that you're bitter about losing the __P() argument, but this kind of sniping is beneath even you. Since you're so eager to deal out advice, allow me to present you with a piece of my own: stop patronizing your fellow committers. People might be more inclined to listen to you if you spent more time mailing out patches and less time lecturing. You're getting more and more like Terry every day. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message